git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/5] t7610-mergetool: add missing && and remove commented-out code

From
David Aguilar <davvid@gmail.com>
Date
Oct 15, 2014, 08:35 UTC
Message-ID
<1413362121-17361-2-git-send-email-davvid@gmail.com>
In-Reply-To
<1413362121-17361-1-git-send-email-davvid@gmail.com>
Signed-off-by: David Aguilar <davvid@gmail.com>
---
 t/t7610-mergetool.sh | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/t/t7610-mergetool.sh b/t/t7610-mergetool.sh
index 875c8af..214edfb 100755
--- a/t/t7610-mergetool.sh
+++ b/t/t7610-mergetool.sh
@@ -192,7 +192,7 @@ test_expect_success 'mergetool merges all from subdir' '
 test_expect_success 'mergetool skips resolved paths when rerere is active' '
 	git config rerere.enabled true &&
 	rm -rf .git/rr-cache &&
-	git checkout -b test5 branch1
+	git checkout -b test5 branch1 &&
 	git submodule update -N &&
 	test_must_fail git merge master >/dev/null 2>&1 &&
 	( yes "l" | git mergetool --no-prompt submod >/dev/null 2>&1 ) &&
@@ -231,18 +231,12 @@ test_expect_success 'conflicted stash sets up rerere'  '
 '
 
 test_expect_success 'mergetool takes partial path' '
-	git reset --hard
+	git reset --hard &&
 	git config rerere.enabled false &&
 	git checkout -b test12 branch1 &&
 	git submodule update -N &&
 	test_must_fail git merge master &&
 
-	#should not need these lines
-	#( yes "d" | git mergetool file11 >/dev/null 2>&1 ) &&
-	#( yes "d" | git mergetool file12 >/dev/null 2>&1 ) &&
-	#( yes "l" | git mergetool submod >/dev/null 2>&1 ) &&
-	#( yes "" | git mergetool file1 file2 >/dev/null 2>&1 ) &&
-
 	( yes "" | git mergetool subdir ) &&
 
 	test "$(cat subdir/file3)" = "master new sub" &&
-- 
2.1.2.453.g1b015e3
Previous: David AguilarNext: David Aguilar
Message 2 of 7 in “t7610-mergetool: use tabs instead of a mix of tabs and spaces”
  1. 1/5 t7610-mergetool: use tabs instead of a mix of tabs and spacesDavid Aguilar, Oct 15, 2014
  2. 2/5 t7610-mergetool: add missing && and remove commented-out codeDavid Aguilar, Oct 15, 2014
  3. 3/5 t7610-mergetool: add test cases for mergetool.writeToTempDavid Aguilar, Oct 15, 2014
  4. 4/5 t7610-mergetool: prefer test_config over git configDavid Aguilar, Oct 15, 2014
  5. 5/5 test-lib-functions: adjust style to match CodingGuidelinesDavid Aguilar, Oct 15, 2014
  6. Junio C HamanoOct 15, 2014
  7. 4/5 t7610-mergetool: use test_config to isolate testsDavid Aguilar, Oct 16, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.