git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] t5704: Complement annotated tag exclusion test

From
LFLukas Fleischer <git@cryptocrack.de>
Date
Aug 4, 2014, 20:57 UTC
Message-ID
<1407185823-9950-1-git-send-email-git@cryptocrack.de>
In-Reply-To
<1406968747-16100-1-git-send-email-git@cryptocrack.de>

In c9a42c4 (bundle: allow rev-list options to exclude annotated tags, 2009-01-02), we added a test to check whether annotated tags, which fall outside the specified date range, are excluded from bundles. Complement this test by also checking whether tags inside the date range are included. Since this addition reveals that the annotated tag exclusion is flawed, mark the test expect-failure for now.

Signed-off-by: Lukas Fleischer <git@cryptocrack.de>
---
I decided that it is still worthwhile to have this in a separate patch.
Feel free to squash 1/2 and 2/2 or let me know that they should be
merged if you prefer that.
 t/t5704-bundle.sh | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/t/t5704-bundle.sh b/t/t5704-bundle.sh
index a45c316..2d53388 100755
--- a/t/t5704-bundle.sh
+++ b/t/t5704-bundle.sh
@@ -14,7 +14,10 @@ test_expect_success 'setup' '
 	git tag -d third
 '
 
-test_expect_success 'tags can be excluded by rev-list options' '
+test_expect_failure 'tags can be excluded by rev-list options' '
+	git bundle create bundle --all --since=7.Apr.2005.15:14:00.-0700 &&
+	git ls-remote bundle > output &&
+	grep tag output &&
 	git bundle create bundle --all --since=7.Apr.2005.15:16:00.-0700 &&
 	git ls-remote bundle > output &&
 	! grep tag output
-- 
2.0.4
Previous: Junio C HamanoNext: Lukas Fleischer
Message 6 of 7 in “t5704: Fix the test that checks for excluded tags”
  1. 1/2 t5704: Fix the test that checks for excluded tagsLukas Fleischer, Aug 2, 2014
  2. 2/2 bundle: Fix exclusion of annotated tagsLukas Fleischer, Aug 2, 2014
  3. Junio C HamanoAug 4, 2014
  4. Junio C HamanoAug 4, 2014
  5. Junio C HamanoAug 4, 2014
  6. 1/2 t5704: Complement annotated tag exclusion testLukas Fleischer, Aug 4, 2014
  7. 2/2 bundle: Fix exclusion of annotated tagsLukas Fleischer, Aug 4, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.