[PATCH 1/2] t5704: Fix the test that checks for excluded tags
- From
- Lukas Fleischer <git@cryptocrack.de>
- Date
- Aug 2, 2014, 08:39 UTC
- Message-ID
- <1406968747-16100-1-git-send-email-git@cryptocrack.de>
In c9a42c4 (bundle: allow rev-list options to exclude annotated tags, 2009-01-02), we added a test to check whether annotated tags, which fall outside the specified date range, are excluded from bundles. However, when initializing the repository, a command to create a lightweight tag was used. Fix this by replacing `git tag` by `git tag -a`. Furthermore, explicitly mention in the test message that an annotated tag is created and also test whether tags within the specified date range are included properly.
Note that this fix reveals that the annotated tag exclusion actually does not work. Therefore, the test is marked expect-failure for now.
Signed-off-by: Lukas Fleischer <git@cryptocrack.de> --- t/t5704-bundle.sh | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/t/t5704-bundle.sh b/t/t5704-bundle.sh index a45c316..2f063ea 100755 --- a/t/t5704-bundle.sh +++ b/t/t5704-bundle.sh @@ -6,7 +6,7 @@ test_description='some bundle related tests' test_expect_success 'setup' ' test_commit initial && test_tick && - git tag -m tag tag && + git tag -am tag tag && test_commit second && test_commit third && git tag -d initial && @@ -14,7 +14,10 @@ test_expect_success 'setup' ' git tag -d third ' -test_expect_success 'tags can be excluded by rev-list options' ' +test_expect_failure 'annotated tags can be excluded by rev-list options' ' + git bundle create bundle --all --since=7.Apr.2005.15:14:00.-0700 && + git ls-remote bundle > output && + grep tag output && git bundle create bundle --all --since=7.Apr.2005.15:16:00.-0700 && git ls-remote bundle > output && ! grep tag output
-- 2.0.3