git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2 v4] tag: support configuring --sort via .gitconfig

From
Keller, Jacob E <jacob.e.keller@intel.com>
Date
Jul 11, 2014, 20:37 UTC
Message-ID
<1405111022.22963.44.camel@jekeller-desk1.amr.corp.intel.com>
In-Reply-To
<xmqqzjgf3g1j.fsf@gitster.dls.corp.google.com>
On Fri, 2014-07-11 at 11:29 -0700, Junio C Hamano wrote:
Show 12 quoted lines
> "Keller, Jacob E" <jacob.e.keller@intel.com> writes:
> 
> > This is not how the rest of the current tests work. I will submit a
> > patch which fixes up the current --sort tests (but not every test, for
> > now) as well.
> 
> I do not want to pile more work that is unrelated to the task at
> hand on your plate, i.e. clean-up work, so I would assign a very low
> priority to "fix up the current tests".  At the same time, existing
> mistakes are not excuses to introduce new similar ones, hence my
> suggestions to the added code in the patch I saw.
>

It was trivial to fix at least the --sort tests, so I submitted a patch that goes before this one to fix those as well.

Thanks, Jake

Previous: Junio C HamanoNext: Keller, Jacob E
Message 8 of 10 in “tag: use skip_prefix instead of magic numbers”
  1. 1/2 tag: use skip_prefix instead of magic numbersJacob Keller, Jul 10, 2014
  2. 2/2 tag: support configuring --sort via .gitconfigJacob Keller, Jul 10, 2014
  3. Junio C HamanoJul 11, 2014
  4. Keller, Jacob EJul 11, 2014
  5. Junio C HamanoJul 11, 2014
  6. Keller, Jacob EJul 11, 2014
  7. Junio C HamanoJul 11, 2014
  8. Keller, Jacob EJul 11, 2014
  9. Keller, Jacob EJul 11, 2014
  10. Duy NguyenJul 16, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.