From: Keller, Jacob E <jacob.e.keller@intel.com>
Date: Fri, 11 Jul 2014 20:37:02 GMT
Subject: Re: [PATCH 2/2 v4] tag: support configuring --sort via .gitconfig
Message-ID: <1405111022.22963.44.camel@jekeller-desk1.amr.corp.intel.com>
In-Reply-To: <xmqqzjgf3g1j.fsf@gitster.dls.corp.google.com>

On Fri, 2014-07-11 at 11:29 -0700, Junio C Hamano wrote:
> "Keller, Jacob E" <jacob.e.keller@intel.com> writes:
> 
> > This is not how the rest of the current tests work. I will submit a
> > patch which fixes up the current --sort tests (but not every test, for
> > now) as well.
> 
> I do not want to pile more work that is unrelated to the task at
> hand on your plate, i.e. clean-up work, so I would assign a very low
> priority to "fix up the current tests".  At the same time, existing
> mistakes are not excuses to introduce new similar ones, hence my
> suggestions to the added code in the patch I saw.
> 

It was trivial to fix at least the --sort tests, so I submitted a patch
that goes before this one to fix those as well.

Thanks,
Jake