git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 8/8] transport-helper: remove unnecessary strbuf resets

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Apr 20, 2014, 18:59 UTC
Message-ID
<1398020370-11406-9-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1398020370-11406-1-git-send-email-felipe.contreras@gmail.com>
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 transport-helper.c | 4 ----
 1 file changed, 4 deletions(-)
diff --git a/transport-helper.c b/transport-helper.c
index 36fbf93..a90094d 100644
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -876,8 +876,6 @@ static int push_refs_with_export(struct transport *transport,
 
 	write_constant(helper->in, "export\n");
 
-	strbuf_reset(&buf);
-
 	for (ref = remote_refs; ref; ref = ref->next) {
 		char *private;
 		unsigned char sha1[20];
@@ -892,8 +890,6 @@ static int push_refs_with_export(struct transport *transport,
 
 		if (ref->peer_ref) {
 			if (strcmp(ref->name, ref->peer_ref->name)) {
-				struct strbuf buf = STRBUF_INIT;
-
 				if (!ref->deletion) {
 					const char *name;
 					int flag;
-- 
1.9.1+fc3.9.gc73078e
Previous: Felipe Contreras
Message 9 of 9 in “transport-helper: refspec support”
  1. 0/8 transport-helper: refspec supportFelipe Contreras, Apr 20, 2014
  2. 1/8 fast-export: improve argument parsingFelipe Contreras, Apr 20, 2014
  3. 2/8 fast-export: add new --refspec optionFelipe Contreras, Apr 20, 2014
  4. 3/8 transport-helper: add support for old:new refspecFelipe Contreras, Apr 20, 2014
  5. 4/8 transport-helper: add support to push symbolic refsFelipe Contreras, Apr 20, 2014
  6. 5/8 fast-import: add support to delete refsFelipe Contreras, Apr 20, 2014
  7. 6/8 fast-export: add support to delete refsFelipe Contreras, Apr 20, 2014
  8. 7/8 transport-helper: add support to delete branchesFelipe Contreras, Apr 20, 2014
  9. 8/8 transport-helper: remove unnecessary strbuf resetsFelipe Contreras, Apr 20, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.