git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] Check for lock failures early

From
Ronnie Sahlberg <sahlberg@google.com>
Date
Apr 15, 2014, 23:46 UTC
Message-ID
<1397605608-12128-1-git-send-email-sahlberg@google.com>

Callers outside of refs.c use either lock_ref_sha1() or lock_any_ref_for_update() to lock a ref during an update.

Two of these places we do not immediately check the lock for failure making reading the code harder.

One place we do some unrelated string manipulation fucntions before we check for failure and the other place we rely on that write_ref_sha1() will check the lock for failure and return an error.

These two patches updates these two places so that we immediately check the lock for failure and act on it. It does not change any functionality or logic but makes the code easier to read by being more consistent.

Ronnie Sahlberg (2):
  sequencer.c: check for lock failure and bail early in fast_forward_to
  commit.c: check for lock error and return early
 builtin/commit.c | 8 ++++----
 sequencer.c      | 7 +++++++
 2 files changed, 11 insertions(+), 4 deletions(-)
-- 
1.9.1.503.ge4c3920.dirty
Next: Ronnie Sahlberg
Message 1 of 4 in “Check for lock failures early”
  1. 0/2 Check for lock failures earlyRonnie Sahlberg, Apr 15, 2014
  2. 1/2 sequencer.c: check for lock failure and bail early in fast_forward_toRonnie Sahlberg, Apr 15, 2014
  3. Brandon CaseyApr 16, 2014
  4. 2/2 commit.c: check for lock error and return earlyRonnie Sahlberg, Apr 15, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.