git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 5/6] cache_tree_find(): remove early return

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Mar 5, 2014, 17:26 UTC
Message-ID
<1394040390-7954-6-git-send-email-mhagger@alum.mit.edu>
In-Reply-To
<1394040390-7954-1-git-send-email-mhagger@alum.mit.edu>
There is no need for an early
    return it;

from the loop if slash points at the end of the string, because that is exactly what will happen when the while condition fails at the start of the next iteration.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
 cache-tree.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/cache-tree.c b/cache-tree.c
index 39ad8c9..17db9f9 100644
--- a/cache-tree.c
+++ b/cache-tree.c
@@ -565,8 +565,6 @@ static struct cache_tree *cache_tree_find(struct cache_tree *it, const char *pat
 		it = sub->cache_tree;
 		while (*slash == '/')
 			slash++;
-		if (!*slash)
-			return it; /* prefix ended with slashes */
 		path = slash;
 	}
 	return it;
-- 
1.9.0
Previous: Michael HaggertyNext: Michael Haggerty
Message 6 of 7 in “cache_tree_find() workover”
  1. 0/6 cache_tree_find() workoverMichael Haggerty, Mar 5, 2014
  2. 1/6 cache_tree_find(): remove redundant checksMichael Haggerty, Mar 5, 2014
  3. 2/6 cache_tree_find(): initialize slash using strchrnul()Michael Haggerty, Mar 5, 2014
  4. 3/6 cache_tree_find(): fix comment formattingMichael Haggerty, Mar 5, 2014
  5. 4/6 cache_tree_find(): remove redundant checkMichael Haggerty, Mar 5, 2014
  6. 5/6 cache_tree_find(): remove early returnMichael Haggerty, Mar 5, 2014
  7. 6/6 cache_tree_find(): use path variable when passing over slashesMichael Haggerty, Mar 5, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.