git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 0/6] cache_tree_find() workover

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Mar 5, 2014, 17:26 UTC
Message-ID
<1394040390-7954-1-git-send-email-mhagger@alum.mit.edu>

Who would have expected so much slop in one little function? Here are the changes coming out of a long email thread.

I feel a little bit silly submitting six separate patches, but they really are independent. And two of the changes were suggested by other people, so splitting those out, at least, helps give credit where it is due. But feel free to squash the patches together if you think it is best.

Changes since v2 (aside from the atomization):
* Use strchrnul() to initialize slash (as suggested by Junio)
* Don't initialize variable at declaration (as per Junio's
  preference).
Thanks to Junio and David for this workout.
Michael Haggerty (6):
  cache_tree_find(): remove redundant checks
  cache_tree_find(): initialize slash using strchrnul()
  cache_tree_find(): fix comment formatting
  cache_tree_find(): remove redundant check
  cache_tree_find(): remove early return
  cache_tree_find(): use path variable when passing over slashes
 cache-tree.c | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)
-- 
1.9.0
Next: Michael Haggerty
Message 1 of 7 in “cache_tree_find() workover”
  1. 0/6 cache_tree_find() workoverMichael Haggerty, Mar 5, 2014
  2. 1/6 cache_tree_find(): remove redundant checksMichael Haggerty, Mar 5, 2014
  3. 2/6 cache_tree_find(): initialize slash using strchrnul()Michael Haggerty, Mar 5, 2014
  4. 3/6 cache_tree_find(): fix comment formattingMichael Haggerty, Mar 5, 2014
  5. 4/6 cache_tree_find(): remove redundant checkMichael Haggerty, Mar 5, 2014
  6. 5/6 cache_tree_find(): remove early returnMichael Haggerty, Mar 5, 2014
  7. 6/6 cache_tree_find(): use path variable when passing over slashesMichael Haggerty, Mar 5, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.