git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] send-email: If the ca path is not specified, use the defaults

From
IGIgor Gnatenko <i.gnatenko.brain@gmail.com>
Date
Jan 15, 2014, 17:31 UTC
Message-ID
<1389807071-26746-1-git-send-email-i.gnatenko.brain@gmail.com>
From: Ruben Kerkhof <ruben@rubenkerkhof.com>
I use gmail for sending patches.
If I have the following defined in my ~/.gitconfig:
[sendemail]
	smtpencryption = tls
	smtpserver = smtp.gmail.com
	smtpuser = ruben@rubenkerkhof.com
	smtpserverport = 587

and try to send a patch, this fails with: STARTTLS failed! SSL connect attempt failed with unknown error error:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed at /usr/libexec/git-core/git-send-email line 1236.

Tested-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
Reference: https://bugzilla.redhat.com/show_bug.cgi?id=1043194
---
 git-send-email.perl | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index 3782c3b..689944f 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -1095,7 +1095,8 @@ sub ssl_verify_params {
 	}
 
 	if (!defined $smtp_ssl_cert_path) {
-		$smtp_ssl_cert_path = "/etc/ssl/certs";
+		# use the OpenSSL defaults
+		return (SSL_verify_mode => SSL_VERIFY_PEER());
 	}
 
 	if ($smtp_ssl_cert_path eq "") {
-- 
1.8.4.2
Next: Junio C Hamano
Message 1 of 11 in “send-email: If the ca path is not specified, use the defaults”
  1. send-email: If the ca path is not specified, use the defaultsIgor Gnatenko, Jan 15, 2014
  2. Junio C HamanoJan 15, 2014
  3. Junio C HamanoJan 15, 2014
  4. Ruben KerkhofJan 15, 2014
  5. Jonathan NiederJan 15, 2014
  6. Junio C HamanoJan 16, 2014
  7. Kyle J. McKayJan 17, 2014
  8. Junio C HamanoJan 17, 2014
  9. Kyle J. McKayJan 17, 2014
  10. Ramkumar RamachandraJan 26, 2014
  11. Junio C HamanoJan 27, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.