Re: [PATCH] send-email: If the ca path is not specified, use the defaults

From: Kyle J. McKay <mackyle@gmail.com>
Date: Jan 17, 2014, 23:34 UTC
Message-ID: <04260036-28A7-45CC-BD25-BED90A7C6DB4@gmail.com>
In-Reply-To: <xmqqlhyexyp4.fsf@gitster.dls.corp.google.com>

On Jan 17, 2014, at 10:14, Junio C Hamano wrote:

Show 7 quoted lines

> If I am reading the code correctly, if /etc/ssl/certs does not exist
> on the filesystem at all, it wouldn't even attempt verification, so
> I take your "the verification will fail" to mean that you forgot to
> also mention "And on OS X, /etc/ssl/certs directory still exists,
> even though OpenSSL does not use it."  If that is the case, then our
> current code indeed is broken in exactly the same way for OS X as
> for Fedora.

My bad. That directory does not normally exist, but, if some errant installer were to create an empty one...

> In short, I agree with you on both counts (the current code is wrong
> for OS X, and the proposed change will fix it).  I just want to make
> sure that my understanding of the current breakage is in line with
> the reality ;-)

Yes, you're right.  :)