git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 08/10] run-command: trivial style fixes

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Sep 28, 2013, 21:51 UTC
Message-ID
<1380405106-29430-9-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1380405106-29430-1-git-send-email-felipe.contreras@gmail.com>
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 run-command.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/run-command.c b/run-command.c
index 1b7f88e..3914d9c 100644
--- a/run-command.c
+++ b/run-command.c
@@ -406,13 +406,12 @@ fail_pipe:
 					unsetenv(*cmd->env);
 			}
 		}
-		if (cmd->git_cmd) {
+		if (cmd->git_cmd)
 			execv_git_cmd(cmd->argv);
-		} else if (cmd->use_shell) {
+		else if (cmd->use_shell)
 			execv_shell_cmd(cmd->argv);
-		} else {
+		else
 			sane_execvp(cmd->argv[0], (char *const*) cmd->argv);
-		}
 		if (errno == ENOENT) {
 			if (!cmd->silent_exec_failure)
 				error("cannot run %s: %s", cmd->argv[0],
@@ -446,7 +445,6 @@ fail_pipe:
 		cmd->pid = -1;
 	}
 	close(notify_pipe[0]);
-
 }
 #else
 {
@@ -480,11 +478,10 @@ fail_pipe:
 	if (cmd->env)
 		env = make_augmented_environ(cmd->env);
 
-	if (cmd->git_cmd) {
+	if (cmd->git_cmd)
 		cmd->argv = prepare_git_cmd(cmd->argv);
-	} else if (cmd->use_shell) {
+	else if (cmd->use_shell)
 		cmd->argv = prepare_shell_cmd(cmd->argv);
-	}
 
 	cmd->pid = mingw_spawnvpe(cmd->argv[0], cmd->argv, env, cmd->dir,
 				  fhin, fhout, fherr);
-- 
1.8.4-fc
Previous: Felipe ContrerasNext: Felipe Contreras
Message 9 of 11 in “trivial style and other fixes”
  1. 00/10 trivial style and other fixesFelipe Contreras, Sep 28, 2013
  2. 01/10 transport-helper: trivial style fixFelipe Contreras, Sep 28, 2013
  3. 02/10 describe: trivial style fixesFelipe Contreras, Sep 28, 2013
  4. 03/10 pretty: trivial style fixFelipe Contreras, Sep 28, 2013
  5. 04/10 revision: trivial style fixesFelipe Contreras, Sep 28, 2013
  6. 05/10 revision: add missing includeFelipe Contreras, Sep 28, 2013
  7. 06/10 shortlog: add missing declarationFelipe Contreras, Sep 28, 2013
  8. 07/10 diff: trivial style fixFelipe Contreras, Sep 28, 2013
  9. 08/10 run-command: trivial style fixesFelipe Contreras, Sep 28, 2013
  10. 09/10 revision: trivial style fixesFelipe Contreras, Sep 28, 2013
  11. 10/10 setup: trivial style fixesFelipe Contreras, Sep 28, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.