git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 04/10] revision: trivial style fixes

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Sep 28, 2013, 21:51 UTC
Message-ID
<1380405106-29430-5-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1380405106-29430-1-git-send-email-felipe.contreras@gmail.com>
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 revision.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/revision.c b/revision.c
index 0173e01..3ebd558 100644
--- a/revision.c
+++ b/revision.c
@@ -2971,7 +2971,7 @@ static struct commit *get_revision_internal(struct rev_info *revs)
 	if (revs->max_count) {
 		c = get_revision_1(revs);
 		if (c) {
-			while (0 < revs->skip_count) {
+			while (revs->skip_count > 0) {
 				revs->skip_count--;
 				c = get_revision_1(revs);
 				if (!c)
@@ -2986,9 +2986,8 @@ static struct commit *get_revision_internal(struct rev_info *revs)
 	if (c)
 		c->object.flags |= SHOWN;
 
-	if (!revs->boundary) {
+	if (!revs->boundary)
 		return c;
-	}
 
 	if (!c) {
 		/*
@@ -3034,9 +3033,8 @@ struct commit *get_revision(struct rev_info *revs)
 
 	if (revs->reverse) {
 		reversed = NULL;
-		while ((c = get_revision_internal(revs))) {
+		while ((c = get_revision_internal(revs)))
 			commit_list_insert(c, &reversed);
-		}
 		revs->commits = reversed;
 		revs->reverse = 0;
 		revs->reverse_output_stage = 1;
-- 
1.8.4-fc
Previous: Felipe ContrerasNext: Felipe Contreras
Message 5 of 11 in “trivial style and other fixes”
  1. 00/10 trivial style and other fixesFelipe Contreras, Sep 28, 2013
  2. 01/10 transport-helper: trivial style fixFelipe Contreras, Sep 28, 2013
  3. 02/10 describe: trivial style fixesFelipe Contreras, Sep 28, 2013
  4. 03/10 pretty: trivial style fixFelipe Contreras, Sep 28, 2013
  5. 04/10 revision: trivial style fixesFelipe Contreras, Sep 28, 2013
  6. 05/10 revision: add missing includeFelipe Contreras, Sep 28, 2013
  7. 06/10 shortlog: add missing declarationFelipe Contreras, Sep 28, 2013
  8. 07/10 diff: trivial style fixFelipe Contreras, Sep 28, 2013
  9. 08/10 run-command: trivial style fixesFelipe Contreras, Sep 28, 2013
  10. 09/10 revision: trivial style fixesFelipe Contreras, Sep 28, 2013
  11. 10/10 setup: trivial style fixesFelipe Contreras, Sep 28, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.