git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 5/7] connect.c: make parse_feature_value() static

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 18, 2013, 05:14 UTC
Message-ID
<1379481263-29903-6-git-send-email-gitster@pobox.com>
In-Reply-To
<1379481263-29903-1-git-send-email-gitster@pobox.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 cache.h   | 1 -
 connect.c | 3 ++-
 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/cache.h b/cache.h
index 85b544f..2c853ba 100644
--- a/cache.h
+++ b/cache.h
@@ -1098,7 +1098,6 @@ extern struct ref **get_remote_heads(int in, char *src_buf, size_t src_len,
 extern int server_supports(const char *feature);
 extern int parse_feature_request(const char *features, const char *feature);
 extern const char *server_feature_value(const char *feature, int *len_ret);
-extern const char *parse_feature_value(const char *feature_list, const char *feature, int *len_ret);
 
 extern struct packed_git *parse_pack_index(unsigned char *sha1, const char *idx_path);
 
diff --git a/connect.c b/connect.c
index a0783d4..e4c7ae6 100644
--- a/connect.c
+++ b/connect.c
@@ -8,6 +8,7 @@
 #include "url.h"
 
 static char *server_capabilities;
+static const char *parse_feature_value(const char *, const char *, int *);
 
 static int check_ref(const char *name, int len, unsigned int flags)
 {
@@ -116,7 +117,7 @@ struct ref **get_remote_heads(int in, char *src_buf, size_t src_len,
 	return list;
 }
 
-const char *parse_feature_value(const char *feature_list, const char *feature, int *lenp)
+static const char *parse_feature_value(const char *feature_list, const char *feature, int *lenp)
 {
 	int len;
 
-- 
1.8.4-585-g8d1dcaf
Previous: Junio C HamanoNext: Junio C Hamano
Message 6 of 8 in “Removing the guesswork of HEAD in "clone"”
  1. 0/7 Removing the guesswork of HEAD in "clone"Junio C Hamano, Sep 18, 2013
  2. 1/7 t5505: fix "set-head --auto with ambiguous HEAD" testJunio C Hamano, Sep 18, 2013
  3. 2/7 upload-pack.c: do not pass confusing cb_data to mark_our_ref()Junio C Hamano, Sep 18, 2013
  4. 3/7 upload-pack: send symbolic ref information as capabilityJunio C Hamano, Sep 18, 2013
  5. 4/7 upload-pack: send non-HEAD symbolic refsJunio C Hamano, Sep 18, 2013
  6. 5/7 connect.c: make parse_feature_value() staticJunio C Hamano, Sep 18, 2013
  7. 6/7 connect: annotate refs with their symref information in get_remote_head()Junio C Hamano, Sep 18, 2013
  8. 7/7 clone: test the new HEAD detection logicJunio C Hamano, Sep 18, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.