git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 1/7] t5505: fix "set-head --auto with ambiguous HEAD" test

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 18, 2013, 05:14 UTC
Message-ID
<1379481263-29903-2-git-send-email-gitster@pobox.com>
In-Reply-To
<1379481263-29903-1-git-send-email-gitster@pobox.com>

When two or more branches point at the same commit and HEAD is pointing at one of them, without the symref extension, there is no way to remotely tell which one of these branches HEAD points at. The test in question attempts to make sure that this situation is diagnosed and results in a failure.

However, even if there _were_ a way to reliably tell which branch the HEAD points at, "set-head --auto" would fail if there is no remote tracking branch. Make sure that this test does not fail for that "wrong" reason.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 * New in this round.
 t/t5505-remote.sh | 1 +
 1 file changed, 1 insertion(+)
diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh
index 8f6e392..197d3f7 100755
--- a/t/t5505-remote.sh
+++ b/t/t5505-remote.sh
@@ -271,6 +271,7 @@ EOF
 test_expect_success 'set-head --auto fails w/multiple HEADs' '
 	(
 		cd test &&
+		git fetch two "refs/heads/*:refs/remotes/two/*" &&
 		test_must_fail git remote set-head --auto two >output 2>&1 &&
 		test_i18ncmp expect output
 	)
-- 
1.8.4-585-g8d1dcaf
Previous: Junio C HamanoNext: Junio C Hamano
Message 2 of 8 in “Removing the guesswork of HEAD in "clone"”
  1. 0/7 Removing the guesswork of HEAD in "clone"Junio C Hamano, Sep 18, 2013
  2. 1/7 t5505: fix "set-head --auto with ambiguous HEAD" testJunio C Hamano, Sep 18, 2013
  3. 2/7 upload-pack.c: do not pass confusing cb_data to mark_our_ref()Junio C Hamano, Sep 18, 2013
  4. 3/7 upload-pack: send symbolic ref information as capabilityJunio C Hamano, Sep 18, 2013
  5. 4/7 upload-pack: send non-HEAD symbolic refsJunio C Hamano, Sep 18, 2013
  6. 5/7 connect.c: make parse_feature_value() staticJunio C Hamano, Sep 18, 2013
  7. 6/7 connect: annotate refs with their symref information in get_remote_head()Junio C Hamano, Sep 18, 2013
  8. 7/7 clone: test the new HEAD detection logicJunio C Hamano, Sep 18, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.