git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] perf-lib: split starting the test from the execution

From
Thomas Gummerer <t.gummerer@gmail.com>
Date
Sep 17, 2013, 12:10 UTC
Message-ID
<1379419842-32627-1-git-send-email-t.gummerer@gmail.com>
Separate the execution part to make future changes to the tests simpler.
Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com>
---
 t/perf/perf-lib.sh | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/t/perf/perf-lib.sh b/t/perf/perf-lib.sh
index c61d535..95e483c 100644
--- a/t/perf/perf-lib.sh
+++ b/t/perf/perf-lib.sh
@@ -148,13 +148,8 @@ exit $ret' >&3 2>&4
 	return "$eval_ret"
 }
 
-
-test_perf () {
+perf_test_ () {
 	test_start_
-	test "$#" = 3 && { test_prereq=$1; shift; } || test_prereq=
-	test "$#" = 2 ||
-	error "bug in the test script: not 2 or 3 parameters to test-expect-success"
-	export test_prereq
 	if ! test_skip "$@"
 	then
 		base=$(basename "$0" .sh)
@@ -191,6 +186,14 @@ test_perf () {
 	test_finish_
 }
 
+test_perf () {
+	test "$#" = 3 && { test_prereq=$1; shift; } || test_prereq=
+	test "$#" = 2 ||
+	error "bug in the test script: not 2 or 3 parameters to test-expect-success"
+	export test_prereq
+	perf_test_ "$1" "$2"
+}
+
 # We extend test_done to print timings at the end (./run disables this
 # and does it after running everything)
 test_at_end_hook_ () {
-- 
1.8.3.4.1238.ga800761
Next: Thomas Gummerer
Message 1 of 12 in “perf-lib: split starting the test from the execution”
  1. 1/2 perf-lib: split starting the test from the executionThomas Gummerer, Sep 17, 2013
  2. 2/2 perf-lib: add test_perf_cleanup targetThomas Gummerer, Sep 17, 2013
  3. Junio C HamanoSep 17, 2013
  4. Thomas GummererSep 19, 2013
  5. Junio C HamanoSep 19, 2013
  6. Junio C HamanoSep 19, 2013
  7. Junio C HamanoSep 19, 2013
  8. Thomas GummererSep 20, 2013
  9. 0/3 Add cleanup action to perf-libThomas Gummerer, Sep 23, 2013
  10. 1/3 test-lib: introduce "modern" style testsThomas Gummerer, Sep 23, 2013
  11. 2/3 perf-lib: add cleanup optionThomas Gummerer, Sep 23, 2013
  12. 3/3 p0003-index.sh: add perf test for the index formatsThomas Gummerer, Sep 23, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.