[RFC PATCHv6 2/2] repack: retain the return value of pack-objects
- From
Stefan Beller <stefanbeller@googlemail.com>
- Date
- Aug 21, 2013, 17:28 UTC
- Message-ID
- <1377106096-28195-2-git-send-email-stefanbeller@googlemail.com>
- In-Reply-To
- <1377106096-28195-1-git-send-email-stefanbeller@googlemail.com>
During the review process of the previous commit (repack: rewrite the shell script in C), Johannes Sixt proposed to retain any exit codes from the sub-process, which makes it probably more obvious in case of failure.
As the commit before should behave as close to the original shell script, the proposed change is put in this extra commit. The infrastructure however was already setup in the previous commit. (Having a local 'ret' variable)
Signed-off-by: Stefan Beller <stefanbeller@googlemail.com> --- builtin/repack.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/repack.c b/builtin/repack.c index fb050c0..1f13e0d 100644 --- a/builtin/repack.c +++ b/builtin/repack.c @@ -231,7 +231,7 @@ int cmd_repack(int argc, const char **argv, const char *prefix) ret = start_command(&cmd); if (ret) - return 1; + return ret; count_packs = 0; out = xfdopen(cmd.out, "r"); @@ -245,7 +245,7 @@ int cmd_repack(int argc, const char **argv, const char *prefix) fclose(out); ret = finish_command(&cmd); if (ret) - return 1; + return ret; argv_array_clear(&cmd_args); if (!count_packs && !quiet)
-- 1.8.4.rc3.1.gc1ebd90