git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 03/11] t8001/t8002: blame: add empty file & partial-line tests

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Jul 31, 2013, 08:15 UTC
Message-ID
<1375258545-42240-4-git-send-email-sunshine@sunshineco.com>
In-Reply-To
<1375258545-42240-1-git-send-email-sunshine@sunshineco.com>

Add boundary case tests, with and without -L, for empty file; file with one partial line; file with one full line.

The empty file test without -L is of particular interest. Historically, this case has been supported (empty blame output) and this test protects against regression by a subsequent patch fixing an off-by-one bug which incorrectly accepts -LX where X is one past end-of-file.

Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
---
 t/annotate-tests.sh | 72 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 72 insertions(+)
diff --git a/t/annotate-tests.sh b/t/annotate-tests.sh
index 02fbbf1..f67332c 100644
--- a/t/annotate-tests.sh
+++ b/t/annotate-tests.sh
@@ -297,6 +297,78 @@ test_expect_success 'blame -L :nomatch' '
 	test_must_fail $PROG -L:nomatch hello.c
 '
 
+test_expect_success 'setup incremental' '
+	(
+	GIT_AUTHOR_NAME=I &&
+	export GIT_AUTHOR_NAME &&
+	GIT_AUTHOR_EMAIL=I@test.git &&
+	export GIT_AUTHOR_EMAIL &&
+	>incremental &&
+	git add incremental &&
+	git commit -m "step 0" &&
+	printf "partial" >>incremental &&
+	git commit -a -m "step 0.5" &&
+	echo >>incremental &&
+	git commit -a -m "step 1"
+	)
+'
+
+test_expect_success 'blame empty' '
+	check_count -h HEAD^^ -f incremental
+'
+
+test_expect_success 'blame -L 0 empty (undocumented)' '
+	check_count -h HEAD^^ -f incremental -L0
+'
+
+test_expect_failure 'blame -L 1 empty' '
+	test_must_fail $PROG -L1 incremental HEAD^^
+'
+
+test_expect_success 'blame -L 2 empty' '
+	test_must_fail $PROG -L2 incremental HEAD^^
+'
+
+test_expect_success 'blame half' '
+	check_count -h HEAD^ -f incremental I 1
+'
+
+test_expect_success 'blame -L 0 half (undocumented)' '
+	check_count -h HEAD^ -f incremental -L0 I 1
+'
+
+test_expect_success 'blame -L 1 half' '
+	check_count -h HEAD^ -f incremental -L1 I 1
+'
+
+test_expect_failure 'blame -L 2 half' '
+	test_must_fail $PROG -L2 incremental HEAD^
+'
+
+test_expect_success 'blame -L 3 half' '
+	test_must_fail $PROG -L3 incremental HEAD^
+'
+
+test_expect_success 'blame full' '
+	check_count -f incremental I 1
+'
+
+test_expect_success 'blame -L 0 full (undocumented)' '
+	check_count -f incremental -L0 I 1
+'
+
+test_expect_success 'blame -L 1 full' '
+	check_count -f incremental -L1 I 1
+'
+
+test_expect_failure 'blame -L 2 full' '
+	test_must_fail $PROG -L2 incremental
+'
+
+test_expect_success 'blame -L 3 full' '
+	test_must_fail $PROG -L3 incremental
+'
+
 test_expect_success 'blame -L' '
 	test_must_fail $PROG -L file
 '
-- 
1.8.3.4.1120.gc240c48
Previous: Junio C HamanoNext: Eric Sunshine
Message 8 of 17 in “blame/log -L: additional tests and bug fixes”
  1. 00/11 blame/log -L: additional tests and bug fixesEric Sunshine, Jul 31, 2013
  2. 01/11 t8001/t8002: blame: decompose overly-large testEric Sunshine, Jul 31, 2013
  3. 02/11 t8001/t8002: blame: demonstrate -L bounds checking bugEric Sunshine, Jul 31, 2013
  4. Junio C HamanoAug 5, 2013
  5. Eric SunshineAug 5, 2013
  6. Eric SunshineAug 5, 2013
  7. Junio C HamanoAug 5, 2013
  8. 03/11 t8001/t8002: blame: add empty file & partial-line testsEric Sunshine, Jul 31, 2013
  9. 04/11 blame: fix -L bounds checking bugEric Sunshine, Jul 31, 2013
  10. 05/11 t4211: log: demonstrate -L bounds checking bugEric Sunshine, Jul 31, 2013
  11. 06/11 t4211: retire soon-to-be unimplementable testsEric Sunshine, Jul 31, 2013
  12. 07/11 log: fix -L bounds checking bugEric Sunshine, Jul 31, 2013
  13. 08/11 t8001/t8002: blame: demonstrate acceptance of bogus -LX,+0 and -LX,-0Eric Sunshine, Jul 31, 2013
  14. 09/11 blame: reject empty ranges -LX,+0 and -LX,-0Eric Sunshine, Jul 31, 2013
  15. 10/11 t8001/t8002: blame: demonstrate acceptance of bogus -L,+0 and -L,-0Eric Sunshine, Jul 31, 2013
  16. 11/11 blame: reject empty ranges -L,+0 and -L,-0Eric Sunshine, Jul 31, 2013
  17. Thomas RastAug 3, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.