git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 01/11] t8001/t8002: blame: decompose overly-large test

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Jul 31, 2013, 08:15 UTC
Message-ID
<1375258545-42240-2-git-send-email-sunshine@sunshineco.com>
In-Reply-To
<1375258545-42240-1-git-send-email-sunshine@sunshineco.com>

Checking all bogus -L syntax forms in a single test makes it difficult to identify the offender when one case fails. Decompose this conglomerate test in order to check each bad syntax case separately.

Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
---
 t/annotate-tests.sh | 32 +++++++++++++++++++++++++-------
 1 file changed, 25 insertions(+), 7 deletions(-)
diff --git a/t/annotate-tests.sh b/t/annotate-tests.sh
index 0bfee00..3524eaf 100644
--- a/t/annotate-tests.sh
+++ b/t/annotate-tests.sh
@@ -275,12 +275,30 @@ test_expect_success 'blame -L :nomatch' '
 	test_must_fail $PROG -L:nomatch hello.c
 '
 
-test_expect_success 'blame -L bogus' '
-	test_must_fail $PROG -L file &&
-	test_must_fail $PROG -L1,+ file &&
-	test_must_fail $PROG -L1,- file &&
-	test_must_fail $PROG -LX file &&
-	test_must_fail $PROG -L1,X file &&
-	test_must_fail $PROG -L1,+N file &&
+test_expect_success 'blame -L' '
+	test_must_fail $PROG -L file
+'
+
+test_expect_success 'blame -L X,+' '
+	test_must_fail $PROG -L1,+ file
+'
+
+test_expect_success 'blame -L X,-' '
+	test_must_fail $PROG -L1,- file
+'
+
+test_expect_success 'blame -L X (non-numeric X)' '
+	test_must_fail $PROG -LX file
+'
+
+test_expect_success 'blame -L X,Y (non-numeric Y)' '
+	test_must_fail $PROG -L1,Y file
+'
+
+test_expect_success 'blame -L X,+N (non-numeric N)' '
+	test_must_fail $PROG -L1,+N file
+'
+
+test_expect_success 'blame -L X,-N (non-numeric N)' '
 	test_must_fail $PROG -L1,-N file
 '
-- 
1.8.3.4.1120.gc240c48
Previous: Eric SunshineNext: Eric Sunshine
Message 2 of 17 in “blame/log -L: additional tests and bug fixes”
  1. 00/11 blame/log -L: additional tests and bug fixesEric Sunshine, Jul 31, 2013
  2. 01/11 t8001/t8002: blame: decompose overly-large testEric Sunshine, Jul 31, 2013
  3. 02/11 t8001/t8002: blame: demonstrate -L bounds checking bugEric Sunshine, Jul 31, 2013
  4. Junio C HamanoAug 5, 2013
  5. Eric SunshineAug 5, 2013
  6. Eric SunshineAug 5, 2013
  7. Junio C HamanoAug 5, 2013
  8. 03/11 t8001/t8002: blame: add empty file & partial-line testsEric Sunshine, Jul 31, 2013
  9. 04/11 blame: fix -L bounds checking bugEric Sunshine, Jul 31, 2013
  10. 05/11 t4211: log: demonstrate -L bounds checking bugEric Sunshine, Jul 31, 2013
  11. 06/11 t4211: retire soon-to-be unimplementable testsEric Sunshine, Jul 31, 2013
  12. 07/11 log: fix -L bounds checking bugEric Sunshine, Jul 31, 2013
  13. 08/11 t8001/t8002: blame: demonstrate acceptance of bogus -LX,+0 and -LX,-0Eric Sunshine, Jul 31, 2013
  14. 09/11 blame: reject empty ranges -LX,+0 and -LX,-0Eric Sunshine, Jul 31, 2013
  15. 10/11 t8001/t8002: blame: demonstrate acceptance of bogus -L,+0 and -L,-0Eric Sunshine, Jul 31, 2013
  16. 11/11 blame: reject empty ranges -L,+0 and -L,-0Eric Sunshine, Jul 31, 2013
  17. Thomas RastAug 3, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.