git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/4] check-ignore -z: a single -z should apply to both input and output

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 12, 2013, 06:18 UTC
Message-ID
<1373609927-3244-4-git-send-email-gitster@pobox.com>
In-Reply-To
<1373609927-3244-1-git-send-email-gitster@pobox.com>

Unless a command has separate --nul-terminated-{input,output} options, the --nul-terminated-records (-z) option should apply to both input and output for consistency. The caller knows that its input paths may need to be protected for LF, and the program shows these problematic paths to its output.

The code already did the right thing. Only the help text needs fixing.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 builtin/check-ignore.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/check-ignore.c b/builtin/check-ignore.c
index be22bce..03e509e 100644
--- a/builtin/check-ignore.c
+++ b/builtin/check-ignore.c
@@ -21,7 +21,7 @@ static const struct option check_ignore_options[] = {
 	OPT_BOOLEAN(0, "stdin", &stdin_paths,
 		    N_("read file names from stdin")),
 	OPT_BOOLEAN('z', NULL, &nul_term_line,
-		    N_("input paths are terminated by a NUL character")),
+		    N_("terminate input and output records by a NUL character")),
 	OPT_END()
 };
 
-- 
1.8.3.2-911-g2c4daa5
Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 6 in “Make check-{attr,ignore} -z consistent”
  1. 0/4 Make check-{attr,ignore} -z consistentJunio C Hamano, Jul 12, 2013
  2. 1/4 check-ignore: the name of the character is NUL, not NULLJunio C Hamano, Jul 12, 2013
  3. 2/4 check-attr: the name of the character is NUL, not NULLJunio C Hamano, Jul 12, 2013
  4. 3/4 check-ignore -z: a single -z should apply to both input and outputJunio C Hamano, Jul 12, 2013
  5. 4/4 check-attr -z: a single -z should apply to both input and outputJunio C Hamano, Jul 12, 2013
  6. Eric SunshineJul 12, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.