git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/4] Make check-{attr,ignore} -z consistent

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 12, 2013, 06:18 UTC
Message-ID
<1373609927-3244-1-git-send-email-gitster@pobox.com>

A command that has to deal with input/output that may contain LF needs to offer the "-z" (--nul-terminated-records) option, and if it does not support separate --nul-terminated-{input,output} options, the "-z" option should govern both input and output. A caller that uses "-z" knows that the paths it feeds to these commands as input may have LF that cannot be expressed in LF delimited input format, and the output from these commands do contain the same paths, so there is no way for their output to be expressed unambiguously for an input that requires "-z".

Unfortunately, "git check-attr -z" was broken and ignored the option on the output side. This is a backward-incompatible fix, so we may need to add a "checkAttr.brokenZ" configuration to allow people to keep the existing breakage on top of these fixes, and then flip the default at Git 2.0 boundary (sometime early next year).

Credit goes to Eric Sunshine for finding this discrepancy ($gmane/230158).

Junio C Hamano (4):
  check-ignore: the name of the character is NUL, not NULL
  check-attr: the name of the character is NUL, not NULL
  check-ignore -z: a single -z should apply to both input and output
  check-attr -z: a single -z should apply to both input and output
 Documentation/git-check-attr.txt |  9 +++++++--
 builtin/check-attr.c             | 20 ++++++++++++++------
 builtin/check-ignore.c           | 12 ++++++------
 3 files changed, 27 insertions(+), 14 deletions(-)
-- 
1.8.3.2-911-g2c4daa5
Next: Junio C Hamano
Message 1 of 6 in “Make check-{attr,ignore} -z consistent”
  1. 0/4 Make check-{attr,ignore} -z consistentJunio C Hamano, Jul 12, 2013
  2. 1/4 check-ignore: the name of the character is NUL, not NULLJunio C Hamano, Jul 12, 2013
  3. 2/4 check-attr: the name of the character is NUL, not NULLJunio C Hamano, Jul 12, 2013
  4. 3/4 check-ignore -z: a single -z should apply to both input and outputJunio C Hamano, Jul 12, 2013
  5. 4/4 check-attr -z: a single -z should apply to both input and outputJunio C Hamano, Jul 12, 2013
  6. Eric SunshineJul 12, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.