[PATCH v2 06/12] do_for_each_entry(): increment the packed refs cache refcount
- From
Michael Haggerty <mhagger@alum.mit.edu>
- Date
- Jun 19, 2013, 07:51 UTC
- Message-ID
- <1371628293-28824-7-git-send-email-mhagger@alum.mit.edu>
- In-Reply-To
- <1371628293-28824-1-git-send-email-mhagger@alum.mit.edu>
This function calls a user-supplied callback function which could do something that causes the packed refs cache to be invalidated. So acquire a reference count on the data structure to prevent our copy from being freed while we are iterating over it.
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> --- refs.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/refs.c b/refs.c index e2e441d..d90f487 100644 --- a/refs.c +++ b/refs.c @@ -1587,10 +1587,12 @@ void warn_dangling_symref(FILE *fp, const char *msg_fmt, const char *refname) static int do_for_each_entry(struct ref_cache *refs, const char *base, each_ref_entry_fn fn, void *cb_data) { - struct ref_dir *packed_dir = get_packed_refs(refs); + struct packed_ref_cache *packed_ref_cache = get_packed_ref_cache(refs); + struct ref_dir *packed_dir = get_packed_ref_dir(packed_ref_cache); struct ref_dir *loose_dir = get_loose_refs(refs); int retval = 0; + acquire_packed_ref_cache(packed_ref_cache); if (base && *base) { packed_dir = find_containing_dir(packed_dir, base, 0); loose_dir = find_containing_dir(loose_dir, base, 0); @@ -1611,6 +1613,7 @@ static int do_for_each_entry(struct ref_cache *refs, const char *base, loose_dir, 0, fn, cb_data); } + release_packed_ref_cache(packed_ref_cache); return retval; }
-- 1.8.3.1