git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 3/3] unpack-trees: free created cache entries

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
May 30, 2013, 13:34 UTC
Message-ID
<1369920861-30030-4-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1369920861-30030-1-git-send-email-felipe.contreras@gmail.com>
We created them, and nobody else is going to destroy them.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 unpack-trees.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/unpack-trees.c b/unpack-trees.c
index eff2944..9f19d01 100644
--- a/unpack-trees.c
+++ b/unpack-trees.c
@@ -590,8 +590,16 @@ static int unpack_nondirectories(int n, unsigned long mask,
 		src[i + o->merge] = create_ce_entry(info, names + i, stage);
 	}
 
-	if (o->merge)
-		return call_unpack_fn(src, o);
+	if (o->merge) {
+		int ret = call_unpack_fn(src, o);
+		for (i = 0; i < n; i++) {
+			struct cache_entry *ce = src[i + o->merge];
+			if (!ce || ce == o->df_conflict_entry)
+				continue;
+			free(ce);
+		}
+		return ret;
+	}
 
 	for (i = 0; i < n; i++)
 		if (src[i] && src[i] != o->df_conflict_entry)
-- 
1.8.3.rc3.312.g47657de
Previous: Stefano LattariniNext: René Scharfe
Message 8 of 9 in “cherry-pick: fix memory leaks”
  1. 0/3 cherry-pick: fix memory leaksFelipe Contreras, May 30, 2013
  2. 1/3 read-cache: plug a few leaksFelipe Contreras, May 30, 2013
  3. René ScharfeMay 30, 2013
  4. Felipe ContrerasMay 31, 2013
  5. Felipe ContrerasMay 31, 2013
  6. 2/3 unpack-trees: plug a memory leakFelipe Contreras, May 30, 2013
  7. Stefano LattariniMay 30, 2013
  8. 3/3 unpack-trees: free created cache entriesFelipe Contreras, May 30, 2013
  9. René ScharfeMay 30, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.