git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 2/3] unpack-trees: plug a memory leak

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
May 30, 2013, 13:34 UTC
Message-ID
<1369920861-30030-3-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1369920861-30030-1-git-send-email-felipe.contreras@gmail.com>

Before overwriting the destination index, first let's discard it's contents.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 unpack-trees.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/unpack-trees.c b/unpack-trees.c
index ede4299..eff2944 100644
--- a/unpack-trees.c
+++ b/unpack-trees.c
@@ -1146,8 +1146,10 @@ int unpack_trees(unsigned len, struct tree_desc *t, struct unpack_trees_options
 
 	o->src_index = NULL;
 	ret = check_updates(o) ? (-2) : 0;
-	if (o->dst_index)
+	if (o->dst_index) {
+		discard_index(o->dst_index);
 		*o->dst_index = o->result;
+	}
 
 done:
 	clear_exclude_list(&el);
-- 
1.8.3.rc3.312.g47657de
Previous: Felipe ContrerasNext: Stefano Lattarini
Message 6 of 9 in “cherry-pick: fix memory leaks”
  1. 0/3 cherry-pick: fix memory leaksFelipe Contreras, May 30, 2013
  2. 1/3 read-cache: plug a few leaksFelipe Contreras, May 30, 2013
  3. René ScharfeMay 30, 2013
  4. Felipe ContrerasMay 31, 2013
  5. Felipe ContrerasMay 31, 2013
  6. 2/3 unpack-trees: plug a memory leakFelipe Contreras, May 30, 2013
  7. Stefano LattariniMay 30, 2013
  8. 3/3 unpack-trees: free created cache entriesFelipe Contreras, May 30, 2013
  9. René ScharfeMay 30, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.