git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/5] rebase: fix 'cherry' mode storage

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
May 28, 2013, 13:29 UTC
Message-ID
<1369747757-10192-3-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1369747757-10192-1-git-send-email-felipe.contreras@gmail.com>
We don't use the 'rebase-apply'.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 git-rebase--cherry.sh | 4 ++++
 git-rebase.sh         | 5 ++++-
 2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/git-rebase--cherry.sh b/git-rebase--cherry.sh
index cbf80f9..ab1f8b7 100644
--- a/git-rebase--cherry.sh
+++ b/git-rebase--cherry.sh
@@ -18,6 +18,9 @@ esac
 
 test -n "$rebase_root" && root_flag=--root
 
+mkdir "$state_dir" || die "Could not create temporary $state_dir"
+: > "$state_dir"/cherry || die "Could not mark as cherry"
+
 # we have to do this the hard way.  git format-patch completely squashes
 # empty commits and even if it didn't the format doesn't really lend
 # itself well to recording empty patches.  fortunately, cherry-pick
@@ -32,3 +35,4 @@ then
 fi
 
 move_to_original_branch
+rm -rf "$state_dir"
diff --git a/git-rebase.sh b/git-rebase.sh
index 2754985..b7759d5 100755
--- a/git-rebase.sh
+++ b/git-rebase.sh
@@ -174,6 +174,9 @@ then
 	then
 		type=interactive
 		interactive_rebase=explicit
+	elif test -f "$merge_dir"/cherry
+	then
+		type=cherry
 	else
 		type=merge
 	fi
@@ -382,7 +385,7 @@ then
 elif test -n "$keep_empty"
 then
 	type=cherry
-	state_dir="$apply_dir"
+	state_dir="$merge_dir"
 else
 	type=am
 	state_dir="$apply_dir"
-- 
1.8.3.rc3.312.g47657de
Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 18 in “rebase: improve the keep-empty”
  1. 0/5 rebase: improve the keep-emptyFelipe Contreras, May 28, 2013
  2. 1/5 rebase: split the cherry-pick stuffFelipe Contreras, May 28, 2013
  3. Junio C HamanoMay 28, 2013
  4. 2/5 rebase: fix 'cherry' mode storageFelipe Contreras, May 28, 2013
  5. Junio C HamanoMay 28, 2013
  6. Felipe ContrerasMay 29, 2013
  7. 3/5 rebase: fix sequence continuationFelipe Contreras, May 28, 2013
  8. Junio C HamanoMay 28, 2013
  9. Felipe ContrerasMay 29, 2013
  10. 4/5 rebase: fix abort of cherry modeFelipe Contreras, May 28, 2013
  11. 5/5 rebase: fix cherry-pick invocationsFelipe Contreras, May 28, 2013
  12. Junio C HamanoMay 28, 2013
  13. Junio C HamanoMay 28, 2013
  14. Felipe ContrerasMay 29, 2013
  15. Felipe ContrerasMay 29, 2013
  16. Felipe ContrerasMay 28, 2013
  17. Martin von ZweigbergkMay 28, 2013
  18. Felipe ContrerasMay 29, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.