[RFC 17/17] refs: document the lifetime of the refname passed to each_ref_fn
- From
Michael Haggerty <mhagger@alum.mit.edu>
- Date
- May 19, 2013, 20:27 UTC
- Message-ID
- <1368995232-11042-18-git-send-email-mhagger@alum.mit.edu>
- In-Reply-To
- <1368995232-11042-1-git-send-email-mhagger@alum.mit.edu>
The lifetime of the refname was never documented, but some callers used to assume that its lifetime was essentially permanent. The commits leading up to this have disabused such callers of that notion.
The new status quo is that the API explicitly does *not* guarantee that the refname string lives beyond a single callback invocation. Document that fact.
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> --- This patch is the ultimate goal of the series, and I include it for illustration, but it obviously shouldn't be committed before the object_array questions have been answered and the rest of the code has been audited more carefully.
refs.h | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a/refs.h b/refs.h index a35eafc..e67fb07 100644 --- a/refs.h +++ b/refs.h @@ -15,13 +15,23 @@ struct ref_lock { #define REF_ISBROKEN 0x04 /* - * Calls the specified function for each ref file until it returns - * nonzero, and returns the value. Please note that it is not safe to - * modify references while an iteration is in progress, unless the - * same callback function invocation that modifies the reference also - * returns a nonzero value to immediately stop the iteration. + * The callback functions for the for_each_*() functions below must + * have this signature. The memory pointed to by the refname argument + * is only guaranteed to be valid for the duration of a single + * callback invocation. + */ +typedef int each_ref_fn(const char *refname, + const unsigned char *sha1, int flags, void *cb_data); + +/* + * The following functions invoke the specified callback function for + * each reference indicated. If the function ever returns a nonzero + * value, stop the iteration and return that value. Please note that + * it is not safe to modify references while an iteration is in + * progress, unless the same callback function invocation that + * modifies the reference also returns a nonzero value to immediately + * stop the iteration. */ -typedef int each_ref_fn(const char *refname, const unsigned char *sha1, int flags, void *cb_data); extern int head_ref(each_ref_fn, void *); extern int for_each_ref(each_ref_fn, void *); extern int for_each_ref_in(const char *, each_ref_fn, void *);
-- 1.8.2.3