[PATCH v2 08/11] sha1_name: avoid Yoda conditions

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 7, 2013, 21:55 UTC
Message-ID: <1367963711-8722-9-git-send-email-felipe.contreras@gmail.com>
In-Reply-To: <1367963711-8722-1-git-send-email-felipe.contreras@gmail.com>

Speak in reverse we shall not; compare variable with constant, not constant with variable.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 sha1_name.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sha1_name.c b/sha1_name.c
index 6530ddd..93c4e8c 100644
--- a/sha1_name.c
+++ b/sha1_name.c
@@ -996,9 +996,9 @@ int interpret_branch_name(const char *name, struct strbuf *buf)
 
 	if (!len)
 		return len; /* syntax Ok, not enough switches */
-	if (0 < len && len == namelen)
+	if (len > 0 && len == namelen)
 		return len; /* consumed all */
-	else if (0 < len) {
+	else if (len > 0) {
 		/* we have extra data, which might need further processing */
 		struct strbuf tmp = STRBUF_INIT;
 		int used = buf->len;

-- 
1.8.3.rc0.401.g45bba44