[PATCH v2 09/11] sha1_name: don't waste cycles in the @-parsing loop
- From
Felipe Contreras <felipe.contreras@gmail.com>
- Date
- May 7, 2013, 21:55 UTC
- Message-ID
- <1367963711-8722-10-git-send-email-felipe.contreras@gmail.com>
- In-Reply-To
- <1367963711-8722-1-git-send-email-felipe.contreras@gmail.com>
From: Ramkumar Ramachandra <artagnon@gmail.com>
The @-parsing loop unnecessarily checks for the sequence "@{" from len - 2 unnecessarily. We can safely check from len - 4.
[fc: remove cruft]
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> --- sha1_name.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sha1_name.c b/sha1_name.c index 93c4e8c..0acc6e0 100644 --- a/sha1_name.c +++ b/sha1_name.c @@ -445,7 +445,7 @@ static int get_sha1_basic(const char *str, int len, unsigned char *sha1) /* basic@{time or number or -number} format to query ref-log */ reflog_len = at = 0; if (len && str[len-1] == '}') { - for (at = len-2; at >= 0; at--) { + for (at = len-4; at >= 0; at--) { if (str[at] == '@' && str[at+1] == '{') { if (!upstream_mark(str + at, len - at)) { reflog_len = (len-1) - (at+2);
-- 1.8.3.rc0.401.g45bba44