git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 09/11] completion: add space after completed filename

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Apr 27, 2013, 10:19 UTC
Message-ID
<1367057994-19887-10-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1367057994-19887-1-git-send-email-felipe.contreras@gmail.com>

Just like before fea16b4 (git-completion.bash: add support for path completion).

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/completion/git-completion.bash |  2 +-
 t/t9902-completion.sh                  | 28 ++++++++++++++--------------
 2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index a9b6a48..60a6a0b 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -247,7 +247,7 @@ __git_index_file_list_filter ()
 	while read -r path; do
 		case "$path" in
 		?*/*) echo "${path%%/*}/" ;;
-		*) echo "$path" ;;
+		*) echo "$path " ;;
 		esac
 	done
 }
diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh
index e6cdb05..8968ef6 100755
--- a/t/t9902-completion.sh
+++ b/t/t9902-completion.sh
@@ -355,12 +355,12 @@ test_expect_success 'complete files' '
 	echo "out" >> .gitignore &&
 
 	git add .gitignore &&
-	test_completion "git commit " ".gitignore" &&
+	test_completion "git commit " ".gitignore " &&
 
 	git commit -m ignore &&
 
 	touch new &&
-	test_completion "git add " "new" &&
+	test_completion "git add " "new " &&
 
 	git add new &&
 	git commit -a -m new &&
@@ -368,22 +368,22 @@ test_expect_success 'complete files' '
 
 	git mv new modified &&
 	echo modify > modified &&
-	test_completion "git add " "modified" &&
+	test_completion "git add " "modified " &&
 
 	touch untracked &&
 
 	: TODO .gitignore should not be here &&
 	test_completion "git rm " <<-\EOF &&
-	.gitignore
-	modified
+	.gitignore Z
+	modified Z
 	EOF
 
-	test_completion "git clean " "untracked" &&
+	test_completion "git clean " "untracked " &&
 
 	: TODO .gitignore should not be here &&
 	test_completion "git mv " <<-\EOF &&
-	.gitignore
-	modified
+	.gitignore Z
+	modified Z
 	EOF
 
 	mkdir dir &&
@@ -395,20 +395,20 @@ test_expect_success 'complete files' '
 
 	: TODO .gitignore should not be here &&
 	test_completion "git mv modified " <<-\EOF &&
-	.gitignore
+	.gitignore Z
 	dir/
-	modified
-	untracked
+	modified Z
+	untracked Z
 	untracked-dir/
 	EOF
 
-	test_completion "git commit " "modified" &&
+	test_completion "git commit " "modified " &&
 
 	: TODO .gitignore should not be here &&
 	test_completion "git ls-files " <<-\EOF
-	.gitignore
+	.gitignore Z
 	dir/
-	modified
+	modified Z
 	EOF
 
 	touch momified &&
-- 
1.8.2.1.1031.g2ee5873
Previous: Felipe ContrerasNext: Felipe Contreras
Message 10 of 19 in “completion: general cleanups”
  1. 00/11 completion: general cleanupsFelipe Contreras, Apr 27, 2013
  2. 01/11 completion: add file completion testsFelipe Contreras, Apr 27, 2013
  3. 02/11 completion: document tilde expansion failure in testsFelipe Contreras, Apr 27, 2013
  4. 03/11 completion; remove unuseful commentsFelipe Contreras, Apr 27, 2013
  5. 04/11 completion: use __gitcompadd for __gitcomp_fileFelipe Contreras, Apr 27, 2013
  6. 05/11 completion: refactor diff_index wrappersFelipe Contreras, Apr 27, 2013
  7. 06/11 completion: refactor __git_complete_index_file()Felipe Contreras, Apr 27, 2013
  8. 07/11 completion: avoid compopt -o filenamesFelipe Contreras, Apr 27, 2013
  9. 08/11 completion: get rid of __gitcomp_file()Felipe Contreras, Apr 27, 2013
  10. 09/11 completion: add space after completed filenameFelipe Contreras, Apr 27, 2013
  11. 10/11 completion: remove __git_index_file_list_filter()Felipe Contreras, Apr 27, 2013
  12. 11/11 completion: zsh: add proper file supportFelipe Contreras, Apr 27, 2013
  13. Manlio PerilloApr 27, 2013
  14. Felipe ContrerasApr 27, 2013
  15. Felipe ContrerasApr 27, 2013
  16. Manlio PerilloApr 27, 2013
  17. Felipe ContrerasApr 27, 2013
  18. Felipe ContrerasApr 27, 2013
  19. Manlio PerilloApr 27, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.