[PATCH 00/11] completion: general cleanups

Hi,

Basically while trying to understand the code for path completion, I found that a lot of code was duplicated, and for not much gain.

I also noticed that doing 'git add file' doesn't add the trailing space as before. It's not clear if it should be possible to do that with -o filenames, but after all, what do -o filenames gives us? Nothing we can't do ourselves, apparently.

However, in zsh the -f option does give us lots of niceties, so there's a patch to allow that in a zsh way.

Also, add the missing tests.

Cheers.

Felipe Contreras (11):
  completion: add file completion tests
  completion: document tilde expansion failure in tests
  completion; remove unuseful comments
  completion: use __gitcompadd for __gitcomp_file
  completion: refactor diff_index wrappers
  completion: refactor __git_complete_index_file()
  completion: avoid compopt -o filenames
  completion: get rid of __gitcomp_file()
  completion: add space after completed filename
  completion: remove __git_index_file_list_filter()
  completion: zsh: add proper file support

 contrib/completion/git-completion.bash | 168 +++++----------------------------
 contrib/completion/git-completion.zsh  |  41 +++++++-
 t/t9902-completion.sh                  |  77 +++++++++++++++
 3 files changed, 140 insertions(+), 146 deletions(-)