git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 6/9] remote-bzr: store converted URL

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Apr 26, 2013, 21:12 UTC
Message-ID
<1367010759-17928-7-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1367010759-17928-1-git-send-email-felipe.contreras@gmail.com>

Bazaar might convert the URL to something more appropriate, like an absolute path. Lets store that instead of the original URL, which won't work from a different working directory if it's relative.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/remote-helpers/git-remote-bzr | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr
index f1d6d5e..dda2932 100755
--- a/contrib/remote-helpers/git-remote-bzr
+++ b/contrib/remote-helpers/git-remote-bzr
@@ -32,7 +32,7 @@ import os
 import json
 import re
 import StringIO
-import atexit, shutil, hashlib
+import atexit, shutil, hashlib, urlparse, subprocess
 
 NAME_RE = re.compile('^([^<>]+)')
 AUTHOR_RE = re.compile('^([^<>]+?)? ?<([^<>]*)>$')
@@ -713,6 +713,14 @@ def get_repo(url, alias):
 
     return branch
 
+def fix_path(alias, orig_url):
+    url = urlparse.urlparse(orig_url, 'file')
+    if url.scheme != 'file' or os.path.isabs(url.path):
+        return
+    abs_url = urlparse.urljoin("%s/" % os.getcwd(), orig_url)
+    cmd = ['git', 'config', 'remote.%s.url' % alias, "bzr::%s" % abs_url]
+    subprocess.call(cmd)
+
 def main(args):
     global marks, prefix, dirname
     global tags, filenodes
@@ -741,6 +749,9 @@ def main(args):
     gitdir = os.environ['GIT_DIR']
     dirname = os.path.join(gitdir, 'bzr', alias)
 
+    if not is_tmp:
+        fix_path(alias, url)
+
     if not os.path.exists(dirname):
         os.makedirs(dirname)
 
-- 
1.8.2.1.1031.g2ee5873
Previous: Felipe ContrerasNext: Felipe Contreras
Message 7 of 15 in “remote-helpers: fixes and cleanups”
  1. 0/9 remote-helpers: fixes and cleanupsFelipe Contreras, Apr 26, 2013
  2. 1/9 remote-helpers: trivial cleanupsFelipe Contreras, Apr 26, 2013
  3. 2/9 remote-hg: remove extra checkFelipe Contreras, Apr 26, 2013
  4. 3/9 remote-bzr: fix bad state issueFelipe Contreras, Apr 26, 2013
  5. 4/9 remote-bzr: add support to push URLsFelipe Contreras, Apr 26, 2013
  6. 5/9 remote-hg: use hashlib instead of hg sha1 utilFelipe Contreras, Apr 26, 2013
  7. 6/9 remote-bzr: store converted URLFelipe Contreras, Apr 26, 2013
  8. 7/9 remote-bzr: tell bazaar to be quietFelipe Contreras, Apr 26, 2013
  9. 8/9 remote-bzr: strip extra newlineFelipe Contreras, Apr 26, 2013
  10. 9/9 remote-bzr: use proper push methodFelipe Contreras, Apr 26, 2013
  11. Junio C HamanoApr 26, 2013
  12. Junio C HamanoApr 26, 2013
  13. Felipe ContrerasApr 26, 2013
  14. Junio C HamanoApr 26, 2013
  15. Ramkumar RamachandraApr 27, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.