git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 1/9] remote-helpers: trivial cleanups

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Apr 26, 2013, 21:12 UTC
Message-ID
<1367010759-17928-2-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1367010759-17928-1-git-send-email-felipe.contreras@gmail.com>

No functional changes. Typos, unused variables, redundant operations, and white-spaces.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/remote-helpers/git-remote-bzr | 7 ++++---
 contrib/remote-helpers/git-remote-hg  | 2 +-
 2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr
index cc6609b..87c54bf 100755
--- a/contrib/remote-helpers/git-remote-bzr
+++ b/contrib/remote-helpers/git-remote-bzr
@@ -94,7 +94,7 @@ class Marks:
         return self.last_mark
 
     def is_marked(self, rev):
-        return str(rev) in self.marks
+        return rev in self.marks
 
     def new_mark(self, rev, mark):
         self.marks[rev] = mark
@@ -224,7 +224,7 @@ def export_files(tree, files):
             else:
                 mode = '100644'
 
-            # is the blog already exported?
+            # is the blob already exported?
             if h in filenodes:
                 mark = filenodes[h]
                 final.append((mode, mark, path))
@@ -521,7 +521,7 @@ def c_style_unescape(string):
     return string
 
 def parse_commit(parser):
-    global marks, blob_marks, bmarks, parsed_refs
+    global marks, blob_marks, parsed_refs
     global mode
 
     parents = []
@@ -643,6 +643,7 @@ def do_export(parser):
                 wt = repo.bzrdir.open_workingtree()
                 wt.update()
         print "ok %s" % ref
+
     print
 
 def do_capabilities(parser):
diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg
index fda4199..cfa96c1 100755
--- a/contrib/remote-helpers/git-remote-hg
+++ b/contrib/remote-helpers/git-remote-hg
@@ -12,7 +12,7 @@
 # For remote repositories a local clone is stored in
 # "$GIT_DIR/hg/origin/clone/.hg/".
 
-from mercurial import hg, ui, bookmarks, context, util, encoding, node, error, extensions
+from mercurial import hg, ui, bookmarks, context, encoding, node, error, extensions
 
 import re
 import sys
-- 
1.8.2.1.1031.g2ee5873
Previous: Felipe ContrerasNext: Felipe Contreras
Message 2 of 15 in “remote-helpers: fixes and cleanups”
  1. 0/9 remote-helpers: fixes and cleanupsFelipe Contreras, Apr 26, 2013
  2. 1/9 remote-helpers: trivial cleanupsFelipe Contreras, Apr 26, 2013
  3. 2/9 remote-hg: remove extra checkFelipe Contreras, Apr 26, 2013
  4. 3/9 remote-bzr: fix bad state issueFelipe Contreras, Apr 26, 2013
  5. 4/9 remote-bzr: add support to push URLsFelipe Contreras, Apr 26, 2013
  6. 5/9 remote-hg: use hashlib instead of hg sha1 utilFelipe Contreras, Apr 26, 2013
  7. 6/9 remote-bzr: store converted URLFelipe Contreras, Apr 26, 2013
  8. 7/9 remote-bzr: tell bazaar to be quietFelipe Contreras, Apr 26, 2013
  9. 8/9 remote-bzr: strip extra newlineFelipe Contreras, Apr 26, 2013
  10. 9/9 remote-bzr: use proper push methodFelipe Contreras, Apr 26, 2013
  11. Junio C HamanoApr 26, 2013
  12. Junio C HamanoApr 26, 2013
  13. Felipe ContrerasApr 26, 2013
  14. Junio C HamanoApr 26, 2013
  15. Ramkumar RamachandraApr 27, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.