git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/6] remote.c: simplify a bit of code using git_config_string()

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
Apr 2, 2013, 07:40 UTC
Message-ID
<1364888434-30388-2-git-send-email-artagnon@gmail.com>
In-Reply-To
<1364888434-30388-1-git-send-email-artagnon@gmail.com>

A small segment where handle_config() parses the branch.remote configuration variable can be simplified using git_config_string().

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 remote.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/remote.c b/remote.c
index ca1edd9..34ddc5b 100644
--- a/remote.c
+++ b/remote.c
@@ -357,9 +357,8 @@ static int handle_config(const char *key, const char *value, void *cb)
 			return 0;
 		branch = make_branch(name, subkey - name);
 		if (!strcmp(subkey, ".remote")) {
-			if (!value)
-				return config_error_nonbool(key);
-			branch->remote_name = xstrdup(value);
+			if (git_config_string(&branch->remote_name, key, value))
+				return -1;
 			if (branch == current_branch) {
 				default_remote_name = branch->remote_name;
 				explicit_default_remote_name = 1;
-- 
1.8.2.363.g901f5bc
Previous: Ramkumar RamachandraNext: Ramkumar Ramachandra
Message 2 of 10 in “Re-roll rr/triangle”
  1. 0/6 Re-roll rr/triangleRamkumar Ramachandra, Apr 2, 2013
  2. 1/6 remote.c: simplify a bit of code using git_config_string()Ramkumar Ramachandra, Apr 2, 2013
  3. 2/6 t5516 (fetch-push): update test descriptionRamkumar Ramachandra, Apr 2, 2013
  4. 3/6 t5516 (fetch-push): drop implicit arguments from helper functionsRamkumar Ramachandra, Apr 2, 2013
  5. 4/6 remote.c: introduce a way to have different remotes for fetch/pushRamkumar Ramachandra, Apr 2, 2013
  6. 5/6 remote.c: introduce remote.pushdefaultRamkumar Ramachandra, Apr 2, 2013
  7. 6/6 remote.c: introduce branch.<name>.pushremoteRamkumar Ramachandra, Apr 2, 2013
  8. Jeff KingApr 2, 2013
  9. Junio C HamanoApr 2, 2013
  10. Jeff KingApr 2, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.