From: Ramkumar Ramachandra Date: Tue, 02 Apr 2013 07:40:29 GMT Subject: [PATCH 1/6] remote.c: simplify a bit of code using git_config_string() Message-ID: <1364888434-30388-2-git-send-email-artagnon@gmail.com> In-Reply-To: <1364888434-30388-1-git-send-email-artagnon@gmail.com> A small segment where handle_config() parses the branch.remote configuration variable can be simplified using git_config_string(). Signed-off-by: Ramkumar Ramachandra --- remote.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/remote.c b/remote.c index ca1edd9..34ddc5b 100644 --- a/remote.c +++ b/remote.c @@ -357,9 +357,8 @@ static int handle_config(const char *key, const char *value, void *cb) return 0; branch = make_branch(name, subkey - name); if (!strcmp(subkey, ".remote")) { - if (!value) - return config_error_nonbool(key); - branch->remote_name = xstrdup(value); + if (git_config_string(&branch->remote_name, key, value)) + return -1; if (branch == current_branch) { default_remote_name = branch->remote_name; explicit_default_remote_name = 1; -- 1.8.2.363.g901f5bc