git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 7/7] perl/Git.pm: rename 'ActiveState' to 'Windows'

From
Gustavo L. de M. Chaves <gnustavo@cpan.org>
Date
Jan 30, 2013, 17:23 UTC
Message-ID
<1359566583-19654-8-git-send-email-gnustavo@cpan.org>
In-Reply-To
<1359566583-19654-1-git-send-email-gnustavo@cpan.org>
From: "Gustavo L. de M. Chaves" <gnustavo@cpan.org>

Windows specific code was mentioning ActiveState Perl specifically, but that code works with Strawberry Perl too.

Hence, we rename every instance of 'ActivePerl' to 'Windows' to convey the more general idea.

Signed-off-by: Gustavo L. de M. Chaves <gnustavo@cpan.org>
---
 perl/Git.pm | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/perl/Git.pm b/perl/Git.pm
index fdef024..e03b82f 100644
--- a/perl/Git.pm
+++ b/perl/Git.pm
@@ -1297,11 +1297,10 @@ sub _command_common_pipe {
 
 	my $fh;
 	if ($^O eq 'MSWin32') {
-		# ActiveState Perl
 		#defined $opts{STDERR} and
-		#	warn 'ignoring STDERR option - running w/ ActiveState';
+		#	warn 'ignoring STDERR option - running on Windows;
 		$direction eq '-|' or
-			die 'input pipe for ActiveState not implemented';
+			die 'input pipe for Windows not implemented';
 
 		# Set up repo environment
 		local $ENV{GIT_DIR}       = $self->repo_path() if defined $self && $self->repo_path();
@@ -1315,13 +1314,13 @@ sub _command_common_pipe {
 			chdir $self->wc_subdir() if $self->wc_subdir();
 		}
 
-		# the strange construction with *ACPIPE is just to
+		# the strange construction with *WINPIPE is just to
 		# explain the tie below that we want to bind to
 		# a handle class, not scalar. It is not known if
-		# it is something specific to ActiveState Perl or
+		# it is something specific to Perl on Windows or
 		# just a Perl quirk.
-		tie (*ACPIPE, 'Git::activestate_pipe', $cmd, @args);
-		$fh = *ACPIPE;
+		tie (*WINPIPE, 'Git::windows_pipe', $cmd, @args);
+		$fh = *WINPIPE;
 
 		chdir $cwd;
 	} else {
@@ -1391,9 +1390,9 @@ sub DESTROY {
 }
 
 
-# Pipe implementation for ActiveState Perl.
+# Pipe implementation for Perl on Windows.
 
-package Git::activestate_pipe;
+package Git::windows_pipe;
 use strict;
 
 sub TIEHANDLE {
-- 
1.7.12.464.g83379df.dirty
Previous: Gustavo L. de M. ChavesNext: Junio C Hamano
Message 8 of 9 in “perl/Git.pm: a bunch of fixes for Windows”
  1. 0/7 perl/Git.pm: a bunch of fixes for WindowsGustavo L. de M. Chaves, Jan 30, 2013
  2. 1/7 perl/Git.pm: test portably if a path is absoluteGustavo L. de M. Chaves, Jan 30, 2013
  3. 2/7 perl/Git.pm: set up command environment on WindowsGustavo L. de M. Chaves, Jan 30, 2013
  4. 3/7 perl/Git.pm: fix _cmd_close on WindowsGustavo L. de M. Chaves, Jan 30, 2013
  5. 4/7 perl/Git.pm: escape external command's arguments on WindowsGustavo L. de M. Chaves, Jan 30, 2013
  6. 5/7 perl/Git.pm: simplify Git::activestate_pipeGustavo L. de M. Chaves, Jan 30, 2013
  7. 6/7 perl/Git.pm: make command pipe work in slurp-mode on WindowsGustavo L. de M. Chaves, Jan 30, 2013
  8. 7/7 perl/Git.pm: rename 'ActiveState' to 'Windows'Gustavo L. de M. Chaves, Jan 30, 2013
  9. Junio C HamanoFeb 25, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.