git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 6/7] perl/Git.pm: make command pipe work in slurp-mode on Windows

From
Gustavo L. de M. Chaves <gnustavo@cpan.org>
Date
Jan 30, 2013, 17:23 UTC
Message-ID
<1359566583-19654-7-git-send-email-gnustavo@cpan.org>
In-Reply-To
<1359566583-19654-1-git-send-email-gnustavo@cpan.org>
From: "Gustavo L. de M. Chaves" <gnustavo@cpan.org>

Git::activestate_pipe::READLINE implementation wasn't working when the pipe was read in slurp-mode (i.e., with $/ undefined).

Now, when in slurp-mode it correctly returns the remaining lines joined together.

Signed-off-by: Gustavo L. de M. Chaves <gnustavo@cpan.org>
---
 perl/Git.pm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/perl/Git.pm b/perl/Git.pm
index 2d88b89..fdef024 100644
--- a/perl/Git.pm
+++ b/perl/Git.pm
@@ -1410,8 +1410,10 @@ sub READLINE {
 	return unless @{$self->{data}};
 	if (wantarray) {
 		return splice @{$self->{data}};
-	} else {
+	} elsif (defined $/) {
 		return shift @{$self->{data}};
+	} else {
+		return join('', splice @{$self->{data}});
 	}
 }
 
-- 
1.7.12.464.g83379df.dirty
Previous: Gustavo L. de M. ChavesNext: Gustavo L. de M. Chaves
Message 7 of 9 in “perl/Git.pm: a bunch of fixes for Windows”
  1. 0/7 perl/Git.pm: a bunch of fixes for WindowsGustavo L. de M. Chaves, Jan 30, 2013
  2. 1/7 perl/Git.pm: test portably if a path is absoluteGustavo L. de M. Chaves, Jan 30, 2013
  3. 2/7 perl/Git.pm: set up command environment on WindowsGustavo L. de M. Chaves, Jan 30, 2013
  4. 3/7 perl/Git.pm: fix _cmd_close on WindowsGustavo L. de M. Chaves, Jan 30, 2013
  5. 4/7 perl/Git.pm: escape external command's arguments on WindowsGustavo L. de M. Chaves, Jan 30, 2013
  6. 5/7 perl/Git.pm: simplify Git::activestate_pipeGustavo L. de M. Chaves, Jan 30, 2013
  7. 6/7 perl/Git.pm: make command pipe work in slurp-mode on WindowsGustavo L. de M. Chaves, Jan 30, 2013
  8. 7/7 perl/Git.pm: rename 'ActiveState' to 'Windows'Gustavo L. de M. Chaves, Jan 30, 2013
  9. Junio C HamanoFeb 25, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.