git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/7] builtin/log.c: stop using global patch_suffix

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 22, 2012, 08:33 UTC
Message-ID
<1356165212-5611-4-git-send-email-gitster@pobox.com>
In-Reply-To
<1356165212-5611-1-git-send-email-gitster@pobox.com>

The suffix for the output filename is found in rev->patch_suffix; do not keep using the global that is only used to parse the command line and configuration.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 builtin/log.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/log.c b/builtin/log.c
index f1d086e..7cf157e 100644
--- a/builtin/log.c
+++ b/builtin/log.c
@@ -673,7 +673,7 @@ static int reopen_stdout(struct commit *commit, const char *subject,
 			 struct rev_info *rev, int quiet)
 {
 	struct strbuf filename = STRBUF_INIT;
-	int suffix_len = strlen(fmt_patch_suffix) + 1;
+	int suffix_len = strlen(rev->patch_suffix) + 1;
 
 	if (output_directory) {
 		strbuf_addstr(&filename, output_directory);
@@ -684,7 +684,7 @@ static int reopen_stdout(struct commit *commit, const char *subject,
 			strbuf_addch(&filename, '/');
 	}
 
-	get_patch_filename(commit, subject, rev->nr, fmt_patch_suffix, &filename);
+	get_patch_filename(commit, subject, rev->nr, rev->patch_suffix, &filename);
 
 	if (!quiet)
 		fprintf(realstdout, "%s\n", filename.buf + outdir_offset);
-- 
1.8.0.6.gd28b5d4.dirty
Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 9 in “format-patch --reroll-count”
  1. 0/7 format-patch --reroll-countJunio C Hamano, Dec 22, 2012
  2. 1/7 builtin/log.c: drop unused "numbered" parameter from make_cover_letter()Junio C Hamano, Dec 22, 2012
  3. 2/7 builtin/log.c: drop redundant "numbered_files" parameter from make_cover_letter()Junio C Hamano, Dec 22, 2012
  4. 3/7 builtin/log.c: stop using global patch_suffixJunio C Hamano, Dec 22, 2012
  5. 4/7 get_patch_filename(): simplify function signatureJunio C Hamano, Dec 22, 2012
  6. 5/7 get_patch_filename(): drop "just-numbers" hackJunio C Hamano, Dec 22, 2012
  7. 6/7 get_patch_filename(): split into two functionsJunio C Hamano, Dec 22, 2012
  8. 7/7 format-patch: add --reroll-count=$N optionJunio C Hamano, Dec 22, 2012
  9. Duy NguyenJan 1, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.