git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/7] builtin/log.c: drop unused "numbered" parameter from make_cover_letter()

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 22, 2012, 08:33 UTC
Message-ID
<1356165212-5611-2-git-send-email-gitster@pobox.com>
In-Reply-To
<1356165212-5611-1-git-send-email-gitster@pobox.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 builtin/log.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/log.c b/builtin/log.c
index 09cf43e..28d9063 100644
--- a/builtin/log.c
+++ b/builtin/log.c
@@ -768,7 +768,7 @@ static void add_branch_description(struct strbuf *buf, const char *branch_name)
 }
 
 static void make_cover_letter(struct rev_info *rev, int use_stdout,
-			      int numbered, int numbered_files,
+			      int numbered_files,
 			      struct commit *origin,
 			      int nr, struct commit **list, struct commit *head,
 			      const char *branch_name,
@@ -1343,7 +1343,7 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
 	if (cover_letter) {
 		if (thread)
 			gen_message_id(&rev, "cover");
-		make_cover_letter(&rev, use_stdout, numbered, numbered_files,
+		make_cover_letter(&rev, use_stdout, numbered_files,
 				  origin, nr, list, head, branch_name, quiet);
 		total++;
 		start_number--;
-- 
1.8.0.6.gd28b5d4.dirty
Previous: Junio C HamanoNext: Junio C Hamano
Message 2 of 9 in “format-patch --reroll-count”
  1. 0/7 format-patch --reroll-countJunio C Hamano, Dec 22, 2012
  2. 1/7 builtin/log.c: drop unused "numbered" parameter from make_cover_letter()Junio C Hamano, Dec 22, 2012
  3. 2/7 builtin/log.c: drop redundant "numbered_files" parameter from make_cover_letter()Junio C Hamano, Dec 22, 2012
  4. 3/7 builtin/log.c: stop using global patch_suffixJunio C Hamano, Dec 22, 2012
  5. 4/7 get_patch_filename(): simplify function signatureJunio C Hamano, Dec 22, 2012
  6. 5/7 get_patch_filename(): drop "just-numbers" hackJunio C Hamano, Dec 22, 2012
  7. 6/7 get_patch_filename(): split into two functionsJunio C Hamano, Dec 22, 2012
  8. 7/7 format-patch: add --reroll-count=$N optionJunio C Hamano, Dec 22, 2012
  9. Duy NguyenJan 1, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.