git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 5/5] submodule: display summary header in bold

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
Oct 2, 2012, 16:51 UTC
Message-ID
<1349196670-2844-6-git-send-email-artagnon@gmail.com>
In-Reply-To
<1349196670-2844-1-git-send-email-artagnon@gmail.com>

Currently, 'git diff --submodule' displays output with a bold diff header for non-submodules. So this part is in bold:

    diff --git a/file1 b/file1
    index 30b2f6c..2638038 100644
    --- a/file1
    +++ b/file1
For submodules, the header looks like this:
    Submodule submodule1 012b072..248d0fd:

Unfortunately, it's easy to miss in the output because it's not bold. Change this.

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 diff.c      |    2 +-
 submodule.c |    8 ++++----
 submodule.h |    2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/diff.c b/diff.c
index 4cb8dd2..cf369c5 100644
--- a/diff.c
+++ b/diff.c
@@ -2240,7 +2240,7 @@ static void builtin_diff(const char *name_a,
 			const char *add = diff_get_color_opt(o, DIFF_FILE_NEW);
 			show_submodule_summary(o->file, one ? one->path : two->path,
 					one->sha1, two->sha1, two->dirty_submodule,
-					del, add, reset);
+					set, del, add, reset);
 			return;
 		}
 	}
diff --git a/submodule.c b/submodule.c
index 50f213e..be60e89 100644
--- a/submodule.c
+++ b/submodule.c
@@ -258,7 +258,7 @@ int parse_fetch_recurse_submodules_arg(const char *opt, const char *arg)
 
 void show_submodule_summary(FILE *f, const char *path,
 		unsigned char one[20], unsigned char two[20],
-		unsigned dirty_submodule,
+		unsigned dirty_submodule, const char *set,
 		const char *del, const char *add, const char *reset)
 {
 	struct rev_info rev;
@@ -292,15 +292,15 @@ void show_submodule_summary(FILE *f, const char *path,
 		return;
 	}
 
-	strbuf_addf(&sb, "Submodule %s %s..", path,
+	strbuf_addf(&sb, "%sSubmodule %s %s..", set, path,
 			find_unique_abbrev(one, DEFAULT_ABBREV));
 	if (!fast_backward && !fast_forward)
 		strbuf_addch(&sb, '.');
 	strbuf_addf(&sb, "%s", find_unique_abbrev(two, DEFAULT_ABBREV));
 	if (message)
-		strbuf_addf(&sb, " %s\n", message);
+		strbuf_addf(&sb, " %s%s\n", message, reset);
 	else
-		strbuf_addf(&sb, "%s:\n", fast_backward ? " (rewind)" : "");
+		strbuf_addf(&sb, "%s:%s\n", fast_backward ? " (rewind)" : "", reset);
 	fwrite(sb.buf, sb.len, 1, f);
 
 	if (!message) {
diff --git a/submodule.h b/submodule.h
index 594b50d..ef5aab6 100644
--- a/submodule.h
+++ b/submodule.h
@@ -20,7 +20,7 @@ void handle_ignore_submodules_arg(struct diff_options *diffopt, const char *);
 int parse_fetch_recurse_submodules_arg(const char *opt, const char *arg);
 void show_submodule_summary(FILE *f, const char *path,
 		unsigned char one[20], unsigned char two[20],
-		unsigned dirty_submodule,
+		unsigned dirty_submodule, const char *set,
 		const char *del, const char *add, const char *reset);
 void set_config_fetch_recurse_submodules(int value);
 void check_for_new_submodule_commits(unsigned char new_sha1[20]);
-- 
1.7.8.1.362.g5d6df.dirty
Previous: Jens Lehmann
Message 14 of 14 in “submodule: introduce diff.submoduleFormat”
  1. 0/5 submodule: introduce diff.submoduleFormatRamkumar Ramachandra, Oct 2, 2012
  2. 1/5 Documentation: move diff.wordRegex from config.txt to diff-config.txtRamkumar Ramachandra, Oct 2, 2012
  3. 2/5 Documentation: sort diff-config.txt alphabeticallyRamkumar Ramachandra, Oct 2, 2012
  4. 3/5 diff: acknowledge --submodule=short command-line optionRamkumar Ramachandra, Oct 2, 2012
  5. Jens LehmannOct 2, 2012
  6. Ramkumar RamachandraOct 7, 2012
  7. Jens LehmannOct 7, 2012
  8. Jens LehmannOct 7, 2012
  9. 4/5 diff: introduce diff.submoduleFormat configuration variableRamkumar Ramachandra, Oct 2, 2012
  10. Jens LehmannOct 2, 2012
  11. Jens LehmannOct 3, 2012
  12. Ramkumar RamachandraOct 29, 2012
  13. Jens LehmannOct 30, 2012
  14. 5/5 submodule: display summary header in boldRamkumar Ramachandra, Oct 2, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.