git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] gitk: Better highlighting of search results

From
Stefan Haller <stefan@haller-berlin.de>
Date
Sep 22, 2012, 07:40 UTC
Message-ID
<1348299625-90207-1-git-send-email-stefan@haller-berlin.de>

Here's something that has been bugging me for a long time: when using the incremental search feature, it's hard to tell what happens when clicking the Search button (or type Ctrl-S) repeatedly. It does have the concept of a "current" search hit, and Ctrl-S advances to the next one; however, you can't see it because all search hits are highlighted in the same way (yellow). So when there are multiple hits visible on the current page, it will at some point scroll down to reveal more hits, but it's impossible to predict when this will happen.

To improve this, we highlight the current search in orange and the other ones in yellow (like Chrome does it when you search on a Web page).

Needs to go on top of the recent "Synchronize highlighting in file view when scrolling diff" patch, v3.

[PATCH 1/2] gitk: Highlight current search hit in orange [PATCH 2/2] gitk: Highlight first search result immediately on incremental search

Next: Stefan Haller
Message 1 of 4 in “gitk: Better highlighting of search results”
  1. 0/2 gitk: Better highlighting of search resultsStefan Haller, Sep 22, 2012
  2. 1/2 gitk: Highlight current search hit in orangeStefan Haller, Sep 22, 2012
  3. 2/2 gitk: Highlight first search result immediately on incremental searchStefan Haller, Sep 22, 2012
  4. Paul MackerrasSep 23, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.