threads / patch / 31625

patch, 2 partsgitk: Highlight first search result immediately on incremental search

Subject: [PATCH 2/2] gitk: Highlight first search result immediately on incremental search

## tl;dr

4 messages between Sep 22, 2012 and Sep 23, 2012. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Stefan Haller· Sep 22, 2012, 07:40 UTC · lore

[PATCH 0/2] gitk: Better highlighting of search results

Here's something that has been bugging me for a long time: when using the incremental search feature, it's hard to tell what happens when clicking the Search button (or type Ctrl-S) repeatedly. It does have the concept of a "current" search hit, and Ctrl-S advances to the next one; however, you can't see it because all search hits are highlighted in the same way (yellow). So when there are multiple hits visible on the current page, it will at some point scroll down to reveal more hits, but it's impossible to predict when this will happen.

To improve this, we highlight the current search in orange and the other ones in yellow (like Chrome does it when you search on a Web page).

Needs to go on top of the recent "Synchronize highlighting in file view when scrolling diff" patch, v3.

[PATCH 1/2] gitk: Highlight current search hit in orange [PATCH 2/2] gitk: Highlight first search result immediately on incremental search

Stefan Haller· Sep 22, 2012, 07:40 UTC · re: Stefan Haller · lore

[PATCH 1/2] gitk: Highlight current search hit in orange

When searching for text in the diff, and there are multiple occurrences of the search string, the current one is highlighted in orange, and the other ones in yellow. This makes it much easier to understand what happens when you then click the Search button or hit Ctrl-S repeatedly.

Signed-off-by: Stefan Haller <stefan@haller-berlin.de>
---
 gitk | 26 +++++++++++++++++++++++---
 1 file changed, 23 insertions(+), 3 deletions(-)
Show changes to gitk +23 −3
diff --git a/gitk b/gitk
index 16832a9..e2c0f1c 100755
--- a/gitk
+++ b/gitk
@@ -2361,6 +2361,7 @@ proc makewindow {} {
     $ctext tag conf mresult -font textfontbold
     $ctext tag conf msep -font textfontbold
     $ctext tag conf found -back yellow
+    $ctext tag conf currentsearchhit -back orange
 
     .pwbottom add .bleft
     if {!$use_ttk} {
@@ -2523,6 +2524,7 @@ proc makewindow {} {
     bind $cflist $ctxbut {pop_flist_menu %W %X %Y %x %y}
     bind $ctext $ctxbut {pop_diff_menu %W %X %Y %x %y}
     bind $ctext <Button-1> {focus %W}
+    bind $ctext <<Selection>> rehighlight_search_results
 
     set maincursor [. cget -cursor]
     set textcursor [$ctext cget -cursor]
@@ -8039,7 +8041,6 @@ proc settabs {{firstab {}}} {
 proc incrsearch {name ix op} {
     global ctext searchstring searchdirn
 
-    $ctext tag remove found 1.0 end
     if {[catch {$ctext index anchor}]} {
 	# no anchor set, use start of selection, or of visible area
 	set sel [$ctext tag ranges sel]
@@ -8058,8 +8059,8 @@ proc incrsearch {name ix op} {
 	    suppress_highlighting_file_for_current_scrollpos
 	    highlightfile_for_scrollpos $here
 	}
-	searchmarkvisible 1
     }
+    rehighlight_search_results
 }
 
 proc dosearch {} {
@@ -8087,6 +8088,7 @@ proc dosearch {} {
 	set mend "$match + $mlen c"
 	$ctext tag add sel $match $mend
 	$ctext mark unset anchor
+	rehighlight_search_results
     }
 }
 
@@ -8115,18 +8117,36 @@ proc dosearchback {} {
 	set mend "$match + $ml c"
 	$ctext tag add sel $match $mend
 	$ctext mark unset anchor
+	rehighlight_search_results
+    }
+}
+
+proc rehighlight_search_results {} {
+    global ctext searchstring
+
+    $ctext tag remove found 1.0 end
+    $ctext tag remove currentsearchhit 1.0 end
+
+    if {$searchstring ne {}} {
+	searchmarkvisible 1
     }
 }
 
 proc searchmark {first last} {
     global ctext searchstring
 
+    set sel [$ctext tag ranges sel]
+
     set mend $first.0
     while {1} {
 	set match [$ctext search -count mlen -- $searchstring $mend $last.end]
 	if {$match eq {}} break
 	set mend "$match + $mlen c"
-	$ctext tag add found $match $mend
+	if {$sel ne {} && [$ctext compare $match == [lindex $sel 0]]} {
+	    $ctext tag add currentsearchhit $match $mend
+	} else {
+	    $ctext tag add found $match $mend
+	}
     }
 }
 

-- 
1.7.12.1.399.gae20e0d
Stefan Haller· Sep 22, 2012, 07:40 UTC · re: Stefan Haller · lore

When typing in the "Search" field, select the current search result (so that it gets highlighted in orange). This makes it easier to understand what will happen if you then type Ctrl-S.

Signed-off-by: Stefan Haller <stefan@haller-berlin.de>
---
 gitk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Show changes to gitk +4 −1
diff --git a/gitk b/gitk
index e2c0f1c..39c40de 100755
--- a/gitk
+++ b/gitk
@@ -8053,9 +8053,12 @@ proc incrsearch {name ix op} {
 	}
     }
     if {$searchstring ne {}} {
-	set here [$ctext search $searchdirn -- $searchstring anchor]
+	set here [$ctext search -count mlen $searchdirn -- $searchstring anchor]
 	if {$here ne {}} {
 	    $ctext see $here
+	    set mend "$here + $mlen c"
+	    $ctext tag remove sel 1.0 end
+	    $ctext tag add sel $here $mend
 	    suppress_highlighting_file_for_current_scrollpos
 	    highlightfile_for_scrollpos $here
 	}

-- 
1.7.12.1.399.gae20e0d
Paul Mackerras· Sep 23, 2012, 06:59 UTC · re: Stefan Haller · lore

Re: [PATCH 0/2] gitk: Better highlighting of search results

On Sat, Sep 22, 2012 at 09:40:23AM +0200, Stefan Haller wrote:
Show 12 quoted lines
> Here's something that has been bugging me for a long time: when using
> the incremental search feature, it's hard to tell what happens when
> clicking the Search button (or type Ctrl-S) repeatedly. It does have
> the concept of a "current" search hit, and Ctrl-S advances to the next
> one; however, you can't see it because all search hits are highlighted
> in the same way (yellow). So when there are multiple hits visible on
> the current page, it will at some point scroll down to reveal more
> hits, but it's impossible to predict when this will happen.
> 
> To improve this, we highlight the current search in orange and the
> other ones in yellow (like Chrome does it when you search on a Web
> page).
Nice, thanks - applied.
Paul.

← back to recent threads