git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v8 03/16] Add svndump_init_fd to allow reading dumps from arbitrary FDs

From
Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
Date
Sep 19, 2012, 15:21 UTC
Message-ID
<1348068090-31988-4-git-send-email-florian.achleitner.2.6.31@gmail.com>
In-Reply-To
<1348068090-31988-3-git-send-email-florian.achleitner.2.6.31@gmail.com>

The existing function only allows reading from a filename or from stdin. Allow passing of a FD and an additional FD for the back report pipe. This allows us to retrieve the name of the pipe in the caller.

Signed-off-by: Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
no diff
 vcs-svn/svndump.c |   22 ++++++++++++++++++----
 vcs-svn/svndump.h |    1 +
 2 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/vcs-svn/svndump.c b/vcs-svn/svndump.c
index 2b168ae..d81a078 100644
--- a/vcs-svn/svndump.c
+++ b/vcs-svn/svndump.c
@@ -468,11 +468,9 @@ void svndump_read(const char *url)
 		end_revision();
 }
 
-int svndump_init(const char *filename)
+static void init(int report_fd)
 {
-	if (buffer_init(&input, filename))
-		return error("cannot open %s: %s", filename, strerror(errno));
-	fast_export_init(REPORT_FILENO);
+	fast_export_init(report_fd);
 	strbuf_init(&dump_ctx.uuid, 4096);
 	strbuf_init(&dump_ctx.url, 4096);
 	strbuf_init(&rev_ctx.log, 4096);
@@ -482,6 +480,22 @@ int svndump_init(const char *filename)
 	reset_dump_ctx(NULL);
 	reset_rev_ctx(0);
 	reset_node_ctx(NULL);
+	return;
+}
+
+int svndump_init(const char *filename)
+{
+	if (buffer_init(&input, filename))
+		return error("cannot open %s: %s", filename ? filename : "NULL", strerror(errno));
+	init(REPORT_FILENO);
+	return 0;
+}
+
+int svndump_init_fd(int in_fd, int back_fd)
+{
+	if(buffer_fdinit(&input, xdup(in_fd)))
+		return error("cannot open fd %d: %s", in_fd, strerror(errno));
+	init(xdup(back_fd));
 	return 0;
 }
 
diff --git a/vcs-svn/svndump.h b/vcs-svn/svndump.h
index df9ceb0..acb5b47 100644
--- a/vcs-svn/svndump.h
+++ b/vcs-svn/svndump.h
@@ -2,6 +2,7 @@
 #define SVNDUMP_H_
 
 int svndump_init(const char *filename);
+int svndump_init_fd(int in_fd, int back_fd);
 void svndump_read(const char *url);
 void svndump_deinit(void);
 void svndump_reset(void);
-- 
1.7.9.5
Previous: Florian AchleitnerNext: Florian Achleitner
Message 4 of 17 in “GSOC remote-svn”
  1. 00/16 GSOC remote-svnFlorian Achleitner, Sep 19, 2012
  2. 01/16 Implement a remote helper for svn in CFlorian Achleitner, Sep 19, 2012
  3. 02/16 Add git-remote-testsvn to MakefileFlorian Achleitner, Sep 19, 2012
  4. 03/16 Add svndump_init_fd to allow reading dumps from arbitrary FDsFlorian Achleitner, Sep 19, 2012
  5. 04/16 Add argv_array_detach and argv_array_free_detachedFlorian Achleitner, Sep 19, 2012
  6. 05/16 Connect fast-import to the remote-helper via pipe, adding 'bidi-import' capabilityFlorian Achleitner, Sep 19, 2012
  7. 06/16 Add documentation for the 'bidi-import' capability of remote-helpersFlorian Achleitner, Sep 19, 2012
  8. 07/16 When debug==1, start fast-import with "--stats" instead of "--quiet"Florian Achleitner, Sep 19, 2012
  9. 08/16 remote-svn, vcs-svn: Enable fetching to private refsFlorian Achleitner, Sep 19, 2012
  10. 09/16 Allow reading svn dumps from files via file:// urlsFlorian Achleitner, Sep 19, 2012
  11. 10/16 vcs-svn: add fast_export_note to create notesFlorian Achleitner, Sep 19, 2012
  12. 11/16 Create a note for every imported commit containing svn metadataFlorian Achleitner, Sep 19, 2012
  13. 12/16 remote-svn: Activate import/export-marks for fast-importFlorian Achleitner, Sep 19, 2012
  14. 13/16 remote-svn: add incremental importFlorian Achleitner, Sep 19, 2012
  15. 14/16 Add a svnrdump-simulator replaying a dump file for testingFlorian Achleitner, Sep 19, 2012
  16. 15/16 remote-svn: add marks-file regenerationFlorian Achleitner, Sep 19, 2012
  17. 16/16 Add a test script for remote-svnFlorian Achleitner, Sep 19, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.