git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v8 12/16] remote-svn: Activate import/export-marks for fast-import

From
Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
Date
Sep 19, 2012, 15:21 UTC
Message-ID
<1348068090-31988-13-git-send-email-florian.achleitner.2.6.31@gmail.com>
In-Reply-To
<1348068090-31988-12-git-send-email-florian.achleitner.2.6.31@gmail.com>

Enable import and export of a marks file by sending the appropriate feature commands to fast-import before sending data.

Signed-off-by: Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
diff:
- seperate strbufs in main
 remote-testsvn.c |   12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/remote-testsvn.c b/remote-testsvn.c
index 67466a9..45eba9f 100644
--- a/remote-testsvn.c
+++ b/remote-testsvn.c
@@ -12,6 +12,7 @@ static const char *url;
 static int dump_from_file;
 static const char *private_ref;
 static const char *remote_ref = "refs/heads/master";
+static const char *marksfilename;
 
 static int cmd_capabilities(const char *line);
 static int cmd_import(const char *line);
@@ -73,6 +74,10 @@ static int cmd_import(const char *line)
 			die("Unable to start %s, code %d", svndump_proc.argv[0], code);
 		dumpin_fd = svndump_proc.out;
 	}
+	/* setup marks file import/export */
+	printf("feature import-marks-if-exists=%s\n"
+			"feature export-marks=%s\n", marksfilename, marksfilename);
+
 	svndump_init_fd(dumpin_fd, STDIN_FILENO);
 	svndump_read(url, private_ref);
 	svndump_deinit();
@@ -145,7 +150,7 @@ static int do_command(struct strbuf *line)
 int main(int argc, const char **argv)
 {
 	struct strbuf buf = STRBUF_INIT, url_sb = STRBUF_INIT,
-			private_ref_sb = STRBUF_INIT;
+			private_ref_sb = STRBUF_INIT, marksfilename_sb = STRBUF_INIT;
 	static struct remote *remote;
 	const char *url_in;
 
@@ -171,6 +176,10 @@ int main(int argc, const char **argv)
 	strbuf_addf(&private_ref_sb, "refs/svn/%s/master", remote->name);
 	private_ref = private_ref_sb.buf;
 
+	strbuf_addf(&marksfilename_sb, "%s/info/fast-import/remote-svn/%s.marks",
+		get_git_dir(), remote->name);
+	marksfilename = marksfilename_sb.buf;
+
 	while (1) {
 		if (strbuf_getline(&buf, stdin, '\n') == EOF) {
 			if (ferror(stdin))
@@ -186,5 +195,6 @@ int main(int argc, const char **argv)
 	strbuf_release(&buf);
 	strbuf_release(&url_sb);
 	strbuf_release(&private_ref_sb);
+	strbuf_release(&marksfilename_sb);
 	return 0;
 }
-- 
1.7.9.5
Previous: Florian AchleitnerNext: Florian Achleitner
Message 13 of 17 in “GSOC remote-svn”
  1. 00/16 GSOC remote-svnFlorian Achleitner, Sep 19, 2012
  2. 01/16 Implement a remote helper for svn in CFlorian Achleitner, Sep 19, 2012
  3. 02/16 Add git-remote-testsvn to MakefileFlorian Achleitner, Sep 19, 2012
  4. 03/16 Add svndump_init_fd to allow reading dumps from arbitrary FDsFlorian Achleitner, Sep 19, 2012
  5. 04/16 Add argv_array_detach and argv_array_free_detachedFlorian Achleitner, Sep 19, 2012
  6. 05/16 Connect fast-import to the remote-helper via pipe, adding 'bidi-import' capabilityFlorian Achleitner, Sep 19, 2012
  7. 06/16 Add documentation for the 'bidi-import' capability of remote-helpersFlorian Achleitner, Sep 19, 2012
  8. 07/16 When debug==1, start fast-import with "--stats" instead of "--quiet"Florian Achleitner, Sep 19, 2012
  9. 08/16 remote-svn, vcs-svn: Enable fetching to private refsFlorian Achleitner, Sep 19, 2012
  10. 09/16 Allow reading svn dumps from files via file:// urlsFlorian Achleitner, Sep 19, 2012
  11. 10/16 vcs-svn: add fast_export_note to create notesFlorian Achleitner, Sep 19, 2012
  12. 11/16 Create a note for every imported commit containing svn metadataFlorian Achleitner, Sep 19, 2012
  13. 12/16 remote-svn: Activate import/export-marks for fast-importFlorian Achleitner, Sep 19, 2012
  14. 13/16 remote-svn: add incremental importFlorian Achleitner, Sep 19, 2012
  15. 14/16 Add a svnrdump-simulator replaying a dump file for testingFlorian Achleitner, Sep 19, 2012
  16. 15/16 remote-svn: add marks-file regenerationFlorian Achleitner, Sep 19, 2012
  17. 16/16 Add a test script for remote-svnFlorian Achleitner, Sep 19, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.