git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] sha1: use char type for temporary work buffer

From
Yann Droneaud <ydroneaud@opteya.com>
Date
Sep 12, 2012, 20:42 UTC
Message-ID
<1347482549.1961.9.camel@test.quest-ce.net>
In-Reply-To
<7v8vcfccbn.fsf@alter.siamese.dyndns.org>
Le mercredi 12 septembre 2012 à 11:42 -0700, Junio C Hamano a écrit :
Show 13 quoted lines
> Yann Droneaud <ydroneaud@opteya.com> writes:
> 
> > The SHA context is holding a temporary buffer for partial block.
> >
> > This block must 64 bytes long. It is currently described as
> > an array of 16 integers.
> >
> > Signed-off-by: Yann Droneaud <ydroneaud@opteya.com>
> > ---
> 
> As we do not work with 16-bit integers anyway, 16 integers occupy 64
> bytes anyway.
> 
It's unclear why this array is declared as 'int' but used as 'char'.
> What problem does this series fix?
>

The question I was hoping to not see asked :) This is mostly some cosmetic fixes to improve readability and portability.

Regards
-- 
Yann Droneaud
OPTEYA
Previous: Junio C Hamano
Message 14 of 14 in “Janitor minor fixes on SHA1”
  1. 0/3 Janitor minor fixes on SHA1Yann Droneaud, Sep 12, 2012
  2. 1/3 sha1: update pointer and remaining length after subfunction callYann Droneaud, Sep 12, 2012
  3. Junio C HamanoSep 12, 2012
  4. 2/3 sha1: clean pointer arithmeticYann Droneaud, Sep 12, 2012
  5. Junio C HamanoSep 12, 2012
  6. Yann DroneaudSep 12, 2012
  7. Bruce KorbSep 12, 2012
  8. 3/3 sha1: use char type for temporary work bufferYann Droneaud, Sep 12, 2012
  9. Jeff KingSep 12, 2012
  10. Yann DroneaudSep 12, 2012
  11. Jeff KingSep 12, 2012
  12. Yann DroneaudSep 13, 2012
  13. Junio C HamanoSep 12, 2012
  14. Yann DroneaudSep 12, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.