From: Yann Droneaud <ydroneaud@opteya.com>
Date: Wed, 12 Sep 2012 20:42:29 GMT
Subject: Re: [PATCH 3/3] sha1: use char type for temporary work buffer
Message-ID: <1347482549.1961.9.camel@test.quest-ce.net>
In-Reply-To: <7v8vcfccbn.fsf@alter.siamese.dyndns.org>

Le mercredi 12 septembre 2012 à 11:42 -0700, Junio C Hamano a écrit :
> Yann Droneaud <ydroneaud@opteya.com> writes:
> 
> > The SHA context is holding a temporary buffer for partial block.
> >
> > This block must 64 bytes long. It is currently described as
> > an array of 16 integers.
> >
> > Signed-off-by: Yann Droneaud <ydroneaud@opteya.com>
> > ---
> 
> As we do not work with 16-bit integers anyway, 16 integers occupy 64
> bytes anyway.
> 

It's unclear why this array is declared as 'int' but used as 'char'.

> What problem does this series fix?
> 

The question I was hoping to not see asked :)
This is mostly some cosmetic fixes to improve readability and
portability.

Regards

-- 
Yann Droneaud
OPTEYA