git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 08/12] git-remote-mediawiki: change return type of get_mw_pages

From
Matthieu Moy <matthieu.moy@imag.fr>
Date
Jul 5, 2012, 07:36 UTC
Message-ID
<1341473772-28023-9-git-send-email-Matthieu.Moy@imag.fr>
In-Reply-To
<1341473772-28023-1-git-send-email-Matthieu.Moy@imag.fr>

The previous version was returning the list of pages to be fetched, but we are going to need an efficient membership test (i.e. is the page $title tracked), hence exposing a hash will be more convenient.

Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---
 contrib/mw-to-git/git-remote-mediawiki | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki b/contrib/mw-to-git/git-remote-mediawiki
index 76b78bc..3f57598 100755
--- a/contrib/mw-to-git/git-remote-mediawiki
+++ b/contrib/mw-to-git/git-remote-mediawiki
@@ -377,7 +377,7 @@ sub get_mw_pages {
 			get_all_mediafiles(\%pages);
 		}
 	}
-	return values(%pages);
+	return %pages;
 }
 
 # usage: $out = run_git("command args");
@@ -563,7 +563,8 @@ my %basetimestamps;
 sub get_last_remote_revision {
 	mw_connect_maybe();
 
-	my @pages = get_mw_pages();
+	my %pages_hash = get_mw_pages();
+	my @pages = values(%pages_hash);
 
 	my $max_rev_num = 0;
 
@@ -829,7 +830,8 @@ sub mw_import_ref {
 
 	mw_connect_maybe();
 
-	my @pages = get_mw_pages();
+	my %pages_hash = get_mw_pages();
+	my @pages = values(%pages_hash);
 
 	print STDERR "Searching revisions...\n";
 	my $last_local = get_last_local_revision();
-- 
1.7.11.1.147.g47a574d
Previous: Matthieu MoyNext: Junio C Hamano
Message 25 of 30 in “git-remote-mediawiki: tests and optimizations”
  1. 00/12 git-remote-mediawiki: tests and optimizationsMatthieu Moy, Jul 5, 2012
  2. 01/12 git-remote-mediawiki: scripts to install, delete and clear a MediaWikiMatthieu Moy, Jul 5, 2012
  3. 02/12 git-remote-mediawiki: test environment of git-remote-mediawikiMatthieu Moy, Jul 5, 2012
  4. Junio C HamanoJul 5, 2012
  5. Matthieu MoyJul 6, 2012
  6. 00/12 git-remote-mediawiki: tests and optimizationsMatthieu Moy, Jul 6, 2012
  7. 01/12 git-remote-mediawiki: scripts to install, delete and clear a MediaWikiMatthieu Moy, Jul 6, 2012
  8. 02/12 git-remote-mediawiki: test environment of git-remote-mediawikiMatthieu Moy, Jul 6, 2012
  9. 03/12 git-remote-mediawiki (t9360): test git-remote-mediawiki cloneMatthieu Moy, Jul 6, 2012
  10. 04/12 git-remote-mediawiki (t9361): test git-remote-mediawiki pull and pushMatthieu Moy, Jul 6, 2012
  11. 05/12 git-remote-mediawiki (t9362): test git-remote-mediawiki with UTF8 charactersMatthieu Moy, Jul 6, 2012
  12. 06/12 git-remote-mediawiki: support for uploading file in test environmentMatthieu Moy, Jul 6, 2012
  13. 07/12 git-remote-mediawiki (t9363): test 'File:' import and exportMatthieu Moy, Jul 6, 2012
  14. 08/12 git-remote-mediawiki: change return type of get_mw_pagesMatthieu Moy, Jul 6, 2012
  15. 09/12 git-remote-mediawiki: refactor loop over revision idsMatthieu Moy, Jul 6, 2012
  16. 10/12 git-remote-mediawiki: extract revision-importing loop to a functionMatthieu Moy, Jul 6, 2012
  17. 11/12 git-remote-mediawiki: more efficient 'pull' in the best caseMatthieu Moy, Jul 6, 2012
  18. 12/12 git-remote-mediawiki: be more defensive when requests failMatthieu Moy, Jul 6, 2012
  19. 03/12 git-remote-mediawiki (t9360): test git-remote-mediawiki cloneMatthieu Moy, Jul 5, 2012
  20. 04/12 git-remote-mediawiki (t9361): test git-remote-mediawiki pull and pushMatthieu Moy, Jul 5, 2012
  21. Junio C HamanoJul 5, 2012
  22. 05/12 git-remote-mediawiki (t9362): test git-remote-mediawiki with UTF8 charactersMatthieu Moy, Jul 5, 2012
  23. 06/12 git-remote-mediawiki: support for uploading file in test environmentMatthieu Moy, Jul 5, 2012
  24. 07/12 git-remote-mediawiki (t9363): test 'File:' import and exportMatthieu Moy, Jul 5, 2012
  25. 08/12 git-remote-mediawiki: change return type of get_mw_pagesMatthieu Moy, Jul 5, 2012
  26. Junio C HamanoJul 5, 2012
  27. 09/12 git-remote-mediawiki: refactor loop over revision idsMatthieu Moy, Jul 5, 2012
  28. 10/12 git-remote-mediawiki: extract revision-importing loop to a functionMatthieu Moy, Jul 5, 2012
  29. 11/12 git-remote-mediawiki: more efficient 'pull' in the best caseMatthieu Moy, Jul 5, 2012
  30. 12/12 git-remote-mediawiki: be more defensive when requests failMatthieu Moy, Jul 5, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.