git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 12/12] git-remote-mediawiki: be more defensive when requests fail

From
Matthieu Moy <matthieu.moy@imag.fr>
Date
Jul 5, 2012, 07:36 UTC
Message-ID
<1341473772-28023-13-git-send-email-Matthieu.Moy@imag.fr>
In-Reply-To
<1341473772-28023-1-git-send-email-Matthieu.Moy@imag.fr>
Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---
 contrib/mw-to-git/git-remote-mediawiki | 8 ++++++++
 1 file changed, 8 insertions(+)
diff --git a/contrib/mw-to-git/git-remote-mediawiki b/contrib/mw-to-git/git-remote-mediawiki
index dd18142..63f02b8 100755
--- a/contrib/mw-to-git/git-remote-mediawiki
+++ b/contrib/mw-to-git/git-remote-mediawiki
@@ -939,6 +939,14 @@ sub mw_import_revids {
 
 		my $result = $mediawiki->api($query);
 
+		if (!$result) {
+			die "Failed to retrieve modified page for revision $pagerevid";
+		}
+
+		if (!defined($result->{query}->{pages})) {
+			die "Invalid revision $pagerevid.";
+		}
+
 		my @result_pages = values(%{$result->{query}->{pages}});
 		my $result_page = $result_pages[0];
 		my $rev = $result_pages[0]->{revisions}->[0];
-- 
1.7.11.1.147.g47a574d
Previous: Matthieu Moy
Message 30 of 30 in “git-remote-mediawiki: tests and optimizations”
  1. 00/12 git-remote-mediawiki: tests and optimizationsMatthieu Moy, Jul 5, 2012
  2. 01/12 git-remote-mediawiki: scripts to install, delete and clear a MediaWikiMatthieu Moy, Jul 5, 2012
  3. 02/12 git-remote-mediawiki: test environment of git-remote-mediawikiMatthieu Moy, Jul 5, 2012
  4. Junio C HamanoJul 5, 2012
  5. Matthieu MoyJul 6, 2012
  6. 00/12 git-remote-mediawiki: tests and optimizationsMatthieu Moy, Jul 6, 2012
  7. 01/12 git-remote-mediawiki: scripts to install, delete and clear a MediaWikiMatthieu Moy, Jul 6, 2012
  8. 02/12 git-remote-mediawiki: test environment of git-remote-mediawikiMatthieu Moy, Jul 6, 2012
  9. 03/12 git-remote-mediawiki (t9360): test git-remote-mediawiki cloneMatthieu Moy, Jul 6, 2012
  10. 04/12 git-remote-mediawiki (t9361): test git-remote-mediawiki pull and pushMatthieu Moy, Jul 6, 2012
  11. 05/12 git-remote-mediawiki (t9362): test git-remote-mediawiki with UTF8 charactersMatthieu Moy, Jul 6, 2012
  12. 06/12 git-remote-mediawiki: support for uploading file in test environmentMatthieu Moy, Jul 6, 2012
  13. 07/12 git-remote-mediawiki (t9363): test 'File:' import and exportMatthieu Moy, Jul 6, 2012
  14. 08/12 git-remote-mediawiki: change return type of get_mw_pagesMatthieu Moy, Jul 6, 2012
  15. 09/12 git-remote-mediawiki: refactor loop over revision idsMatthieu Moy, Jul 6, 2012
  16. 10/12 git-remote-mediawiki: extract revision-importing loop to a functionMatthieu Moy, Jul 6, 2012
  17. 11/12 git-remote-mediawiki: more efficient 'pull' in the best caseMatthieu Moy, Jul 6, 2012
  18. 12/12 git-remote-mediawiki: be more defensive when requests failMatthieu Moy, Jul 6, 2012
  19. 03/12 git-remote-mediawiki (t9360): test git-remote-mediawiki cloneMatthieu Moy, Jul 5, 2012
  20. 04/12 git-remote-mediawiki (t9361): test git-remote-mediawiki pull and pushMatthieu Moy, Jul 5, 2012
  21. Junio C HamanoJul 5, 2012
  22. 05/12 git-remote-mediawiki (t9362): test git-remote-mediawiki with UTF8 charactersMatthieu Moy, Jul 5, 2012
  23. 06/12 git-remote-mediawiki: support for uploading file in test environmentMatthieu Moy, Jul 5, 2012
  24. 07/12 git-remote-mediawiki (t9363): test 'File:' import and exportMatthieu Moy, Jul 5, 2012
  25. 08/12 git-remote-mediawiki: change return type of get_mw_pagesMatthieu Moy, Jul 5, 2012
  26. Junio C HamanoJul 5, 2012
  27. 09/12 git-remote-mediawiki: refactor loop over revision idsMatthieu Moy, Jul 5, 2012
  28. 10/12 git-remote-mediawiki: extract revision-importing loop to a functionMatthieu Moy, Jul 5, 2012
  29. 11/12 git-remote-mediawiki: more efficient 'pull' in the best caseMatthieu Moy, Jul 5, 2012
  30. 12/12 git-remote-mediawiki: be more defensive when requests failMatthieu Moy, Jul 5, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.