[PATCH v2 3/3] gitweb: Add support to Link: tag
- From
Namhyung Kim <namhyung@kernel.org>
- Date
- Jul 4, 2012, 02:47 UTC
- Message-ID
- <1341370046-19913-3-git-send-email-namhyung@kernel.org>
- In-Reply-To
- <1341370046-19913-1-git-send-email-namhyung@kernel.org>
The tip tree is the one of major subsystem tree in the Linux kernel project. On the tip tree, the Link: (or similar Buglink:) tag is used for tracking the original discussion or context. Since it's ususally in the S-o-b area, it'd be better using same style with others.
Also as it tends to contain a message-id sent from git send-email, a part of the line would set a wrong hyperlink like [1]. Fix it by not using format_log_line_html().
[1] git.kernel.org/?p=linux/kernel/git/tip/tip.git;a=commit;h=08942f6d5d992e9486b07653fd87ea8182a22fa0
Signed-off-by: Namhyung Kim <namhyung@kernel.org> --- gitweb/gitweb.perl | 10 ++++++++++ 1 file changed, 10 insertions(+)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 362784d..3d6a705 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -4494,6 +4494,16 @@ sub git_print_log { next; } + if ($line =~ m,\s*([a-z]*link): (https?://\S+),i) { + if (! $opts{'-remove_signoff'}) { + print "<span class=\"signoff\">" . esc_html($1) . ": " . + "<a href=\"" . esc_html($2) . "\">" . esc_html($2) . "</a>" . + "</span><br/>\n"; + $skip_blank_line = 1; + } + next; + } + # print only one empty line # do not print empty line after signoff if ($line eq "") {
-- 1.7.10.4