git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 2/3] gitweb: Handle other types of tag in git_print_log

From
Namhyung Kim <namhyung@kernel.org>
Date
Jul 4, 2012, 02:47 UTC
Message-ID
<1341370046-19913-2-git-send-email-namhyung@kernel.org>
In-Reply-To
<1341370046-19913-1-git-send-email-namhyung@kernel.org>

There are many types of tags used in S-o-b area [1]. Update the regex to handle them properly. It requires the tag should be started by a capital letter and ended by '-by: ' or '-By: '. The only exception is 'Cc: '.

[1] http://lwn.net/Articles/503829/
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 gitweb/gitweb.perl |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 82c5da7..362784d 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -4486,7 +4486,7 @@ sub git_print_log {
 	# print log
 	my $skip_blank_line = 0;
 	foreach my $line (@$log) {
-		if ($line =~ m/^ *(signed[ \-]off[ \-]by[ :]|acked[ \-]by[ :]|cc[ :])/i) {
+		if ($line =~ m/^\s*([A-Z][-A-Za-z]*-[Bb]y|C[Cc]): /) {
 			if (! $opts{'-remove_signoff'}) {
 				print "<span class=\"signoff\">" . esc_html($line) . "</span><br/>\n";
 				$skip_blank_line = 1;
-- 
1.7.10.4
Previous: Namhyung KimNext: Namhyung Kim
Message 2 of 5 in “gitweb: Cleanup git_print_log()”
  1. 1/3 gitweb: Cleanup git_print_log()Namhyung Kim, Jul 4, 2012
  2. 2/3 gitweb: Handle other types of tag in git_print_logNamhyung Kim, Jul 4, 2012
  3. 3/3 gitweb: Add support to Link: tagNamhyung Kim, Jul 4, 2012
  4. Junio C HamanoJul 5, 2012
  5. Junio C HamanoJul 5, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.