git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 3/9] sha1_name.c: rename "now" to "current"

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 24, 2012, 00:11 UTC
Message-ID
<1340496691-12258-4-git-send-email-gitster@pobox.com>
In-Reply-To
<1340496691-12258-1-git-send-email-gitster@pobox.com>

This variable points at the element we are currently looking at, and does not have anything to do with the current time which the name "now" implies.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 sha1_name.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/sha1_name.c b/sha1_name.c
index 4cbca34..5224f39 100644
--- a/sha1_name.c
+++ b/sha1_name.c
@@ -93,11 +93,11 @@ static int find_short_packed_object(int len, const unsigned char *match, unsigne
 		last = num;
 		while (first < last) {
 			uint32_t mid = (first + last) / 2;
-			const unsigned char *now;
+			const unsigned char *current;
 			int cmp;
 
-			now = nth_packed_object_sha1(p, mid);
-			cmp = hashcmp(match, now);
+			current = nth_packed_object_sha1(p, mid);
+			cmp = hashcmp(match, current);
 			if (!cmp) {
 				first = mid;
 				break;
@@ -109,17 +109,17 @@ static int find_short_packed_object(int len, const unsigned char *match, unsigne
 			last = mid;
 		}
 		if (first < num) {
-			const unsigned char *now, *next;
-			now = nth_packed_object_sha1(p, first);
-			if (match_sha(len, match, now)) {
+			const unsigned char *current, *next;
+			current = nth_packed_object_sha1(p, first);
+			if (match_sha(len, match, current)) {
 				next = nth_packed_object_sha1(p, first+1);
 				if (!next|| !match_sha(len, match, next)) {
 					/* unique within this pack */
 					if (!found) {
-						found_sha1 = now;
+						found_sha1 = current;
 						found++;
 					}
-					else if (hashcmp(found_sha1, now)) {
+					else if (hashcmp(found_sha1, current)) {
 						found = 2;
 						break;
 					}
-- 
1.7.11.1.29.gf71be5c
Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 11 in “Extending the shelf-life of "git describe" output”
  1. 0/9 Extending the shelf-life of "git describe" outputJunio C Hamano, Jun 24, 2012
  2. 1/9 sha1_name.c: indentation fixJunio C Hamano, Jun 24, 2012
  3. 2/9 sha1_name.c: clarify what "fake" is for in find_short_object_filename()Junio C Hamano, Jun 24, 2012
  4. 3/9 sha1_name.c: rename "now" to "current"Junio C Hamano, Jun 24, 2012
  5. 4/9 sha1_name.c: refactor find_short_packed_object()Junio C Hamano, Jun 24, 2012
  6. 5/9 sha1_name.c: correct misnamed "canonical" and "res"Junio C Hamano, Jun 24, 2012
  7. 6/9 sha1_name.c: restructure disambiguation of short namesJunio C Hamano, Jun 24, 2012
  8. 7/9 sha1_name.c: allow get_short_sha1() to take other flagsJunio C Hamano, Jun 24, 2012
  9. 8/9 sha1_name.c: teach get_short_sha1() a commit-only optionJunio C Hamano, Jun 24, 2012
  10. 9/9 sha1_name.c: get_describe_name() by definition groks only commitsJunio C Hamano, Jun 24, 2012
  11. Junio C HamanoJun 24, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.